Skip to content

Commit

Permalink
fix(quality) Do not force desktop codecs on mobile.
Browse files Browse the repository at this point in the history
If the mobileCodecPreferenceOrder setting is missing, use the default order for mobile. Fixes an issue where mobile endpoints encodes using AV1 when mobile settings are missing.
  • Loading branch information
jallamsetty1 authored and saghul committed Sep 13, 2024
1 parent 5c74c39 commit cf14a33
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions JitsiConference.js
Original file line number Diff line number Diff line change
Expand Up @@ -444,8 +444,8 @@ JitsiConference.prototype._init = function(options = {}) {
enableAdaptiveMode: config.videoQuality?.enableAdaptiveMode,
lastNRampupTime: config.testing?.lastNRampupTime ?? 60000,
jvb: {
preferenceOrder: browser.isMobileDevice() && config.videoQuality?.mobileCodecPreferenceOrder
? config.videoQuality.mobileCodecPreferenceOrder
preferenceOrder: browser.isMobileDevice()
? config.videoQuality?.mobileCodecPreferenceOrder
: config.videoQuality?.codecPreferenceOrder,
disabledCodec: _getCodecMimeType(config.videoQuality?.disabledCodec),
preferredCodec: _getCodecMimeType(config.videoQuality?.preferredCodec),
Expand All @@ -454,8 +454,8 @@ JitsiConference.prototype._init = function(options = {}) {
: _getCodecMimeType(config.videoQuality?.screenshareCodec)
},
p2p: {
preferenceOrder: browser.isMobileDevice() && config.p2p?.mobileCodecPreferenceOrder
? config.p2p.mobileCodecPreferenceOrder
preferenceOrder: browser.isMobileDevice()
? config.p2p?.mobileCodecPreferenceOrder
: config.p2p?.codecPreferenceOrder,
disabledCodec: _getCodecMimeType(config.p2p?.disabledCodec),
preferredCodec: _getCodecMimeType(config.p2p?.preferredCodec),
Expand Down

0 comments on commit cf14a33

Please sign in to comment.