fix: added better types

[vasav-prashar]

@hristoterezov @saghul @bgrozev can you please review this.

[jitsi-jenkins]

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

[Parth0105]

@hristoterezov @saghul @bgrozev can you please review this.

[saghul]

Sorry, what are you fixing here? "other" is still unaccounted for.

[Parth0105]

Sorry, what are you fixing here? "other" is still unaccounted for.

only thing exported from import * as exported from "./AuthenticationEvents"; is IDENTITY_UPDATED: 'authentication.identity_updated'

const AuthenticationEvents = {
    /**
     * Event callback arguments:
     * function(authenticationEnabled, userIdentity)
     * authenticationEnabled - indicates whether authentication has been enabled
     *                         in this session
     * userIdentity - if user has been logged in then it contains user name. If
     *                contains 'null' or 'undefined' then user is not logged in.
     */
    IDENTITY_UPDATED: 'authentication.identity_updated'
};

can just replace

{
        IDENTITY_UPDATED,
        AuthenticationEvents,
        ...others
 }

with { IDENTITY_UPDATED }

[Parth0105]

Sorry, what are you fixing here? "other" is still unaccounted for.

@saghul

[saghul]

The whole point of that test is to make sure we don't miss any other exports. Maybe I'm missing something...

[Parth0105]

The whole point of that test is to make sure we don't miss any other exports. Maybe I'm missing something...

{
        IDENTITY_UPDATED: string,
        AuthenticationEvents: { IDENTITY_UPDATED: string },
} & { [key: string]: unknown }

i guess this would be a better type then taking into account any unneeded exports? @saghul

[NewEraCracker]

PTAL