Var methods and ExtendFormula to make it easier to construct formulas #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows requesting new variables and, in the future, will allow code that is generic over CnfFormula and Solver.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 18, 2019
55: Var methods and ExtendFormula to make it easier to construct formulas r=jix a=jix This resolves #18 Co-authored-by: Jannis Harder <[email protected]>
Eh2406
reviewed
May 18, 2019
| pub trait ExtendFormula: Sized { | ||
| /// Appends a clause to the formula. | ||
| /// | ||
| /// `literals` can be an `IntoIterator<Item = Lit>` or `IntoIterator<Item = &Lit>`. |
There was a problem hiding this comment.
The comment seam wrong here. This does not take a IntoIterator it takes a &[Lit]. Also If this replaces the removed add_clause above, then that is a semver breaking change.
let a = HashSet<Lit> ={...};
let mut b = CnfFormula::new();
b.add_clause(a.iter());
Works before and does not compile now.
There was a problem hiding this comment.
Ah I missed updating the documentation here, thanks for spotting that. It's not semver breaking as I'm still on 0.x.y. Maybe I should add a more explicit warning that the API isn't stable yet. I will release a version 1.0 when I'm done tweaking the API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #18