Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSL support #10

Open
dorseydick opened this issue May 19, 2014 · 8 comments
Open

Add SSL support #10

dorseydick opened this issue May 19, 2014 · 8 comments

Comments

@dorseydick
Copy link

It would be great if this would support SSL connections. Right now we're using stomp+ssl on port 61613 so we can't use straight tcp connections.

@jjeffery
Copy link
Owner

If you want to connect to a server using SSL, you can initiate the connection yourself, and then setup the STOMP connection using the following function:

  func Connect(conn io.ReadWriteCloser, opts Options) (*Conn, error)

Or are you using the simple STOMP server implementation and want it to support SSL?

@dorseydick
Copy link
Author

Sorry, I'm still new to go and have been trying to figure out how to do
this. Just a connection to a server, namely ActiveMQ.

On Mon, May 19, 2014 at 7:05 PM, John Jeffery [email protected]:

If you want to connect to a server using SSL, you can initiate the
connection yourself, and then setup the STOMP connection using the
following function:

func Connect(conn io.ReadWriteCloser, opts Options) (*Conn, error)

Or are you using the simple STOMP server implementation and want it to
support SSL?


Reply to this email directly or view it on GitHubhttps://github.com//issues/10#issuecomment-43569212
.

@jjeffery
Copy link
Owner

To create an SSL connection, use the crypto/tls package. See http://golang.org/pkg/crypto/tls/#Dial for details of the function to use to create a connection. The tls.Conn that this function returns can then be passed to the stomp.Connect function, because it implements the io.ReadWriteCloser interface.

@flowchartsman
Copy link

This issue is still open, were you planning on adding a convenience method or something?

@jjeffery
Copy link
Owner

@alaska: Pull requests are very welcome.

@flowchartsman
Copy link

Is this the place to do it, or is go-stomp where all the happenings are?

@jjeffery
Copy link
Owner

jjeffery commented May 4, 2015

To be honest, I'm not all that sure. I moved the code to the go-stomp
project after the announcement of gopkg, but since that time I'm not sure
that it has been picked up by all that many projects. There are some
members of the go team who are quite against the concept.

I wish I had not created the go-stomp repository, but now that it's there
I'm sure it would cause problems if I removed it. Which repository have you
been using?

On Fri, 24 Apr 2015 at 15:07 Andy Walker [email protected] wrote:

Is this the place to do it, or is go-stomp where all the happenings are?


Reply to this email directly or view it on GitHub
#10 (comment).

@flowchartsman
Copy link

go-stomp, if only because it looked more authoritative, what with its official-sounding name and all. I'm perfectly fine checking in here, however. I, too, am very reluctant to use gopkg.in, and kind of prefer in-repository versioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants