Correctly guessing spectral widths in multidimensional datasets #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks for the fix @kaustubhmote. This might help with #97 as well. |
|
Ya, that is what I was trying to fix when I saw this. However #97 seems to have some issue in the direct dimension, which should have be read correctly even without this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bruker.guess_udicand the underlyingadd_axes_to_udiconly looked up parameters present in theacqusfile and failed for higher dimensions. TheSW_hkey is not available for indirect dimensions and the spectral width is now calculated fromSWandSFO1parameters. This PR does not change default behavior.