Put Perl run files in _common consistently #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `ThirdMigration` tutorial part, I noticed that the Perl run files weren't put into the `share/migrations/_common` path as had been the case in earlier tutorial parts. This seemed inconsistent with the rest of the tutorial and surprised me as a reader, hence this change alters the paths of these files to be in the `_common` path (and adds a command to create the appropriate `upgrade` directory). The change has also been tested to ensure that it still works as intended within the tutorial.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
ThirdMigrationtutorial part, I noticed that the Perl run files weren't put into theshare/migrations/_commonpath as had been the case in earlier tutorial parts. This seemed inconsistent with the rest of the tutorial and surprised me as a reader, hence this change alters the paths of these files to be in the_commonpath (and adds a command to create the appropriateupgradedirectory). The change has also been tested to ensure that it still works as intended within the tutorial.This PR is submitted in the hope that it is useful. If you wish for any changes, please don't hesitate to contact me and I'll be more than happy to update and resubmit as necessary.