Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moo Conversion #31

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Moo Conversion #31

wants to merge 4 commits into from

Conversation

felliott
Copy link
Contributor

Hey John,

This branch switches TDBIC to use Moo & Type::Tiny instead of Moose, MooseX::Types, and MooseX::Attributes::ENV. It's a bit moot since Data::Visitor still depends on Moose, but I thought you or someone else might be interested. Please let me know if you'd like me to make any changes. Thank you!

Cheers,
Fitz

@jjn1056
Copy link
Owner

jjn1056 commented Sep 29, 2014

People have been broadly interesting. I'll cut some time to take a look and if its all goodish why not try a dev release? we can alway back down if it breaks too much stuff :)

@jjn1056
Copy link
Owner

jjn1056 commented Nov 3, 2014

@felliott hey I hate to ask but I merged up some stuff and built a new release. If you have time can you bring this patch up to current (resolve conflicts?) looks like this had some patch you also sent separately. thanks

@felliott
Copy link
Contributor Author

felliott commented Nov 3, 2014

On Nov 3, 2014, at 11:37 AM, John Napiorkowski [email protected] wrote:

@felliott hey I hate to ask but I merged up some stuff and built a new release. If you have time can you bring this patch up to current (resolve conflicts?) looks like this had some patch you also sent separately. thanks

Hey John,

No problem and thanks for merging the other set!

Cheers,
Fitz=

@felliott
Copy link
Contributor Author

felliott commented Nov 3, 2014

@felliott hey I hate to ask but I merged up some stuff and built a new release. If you have time can you bring this patch up to current (resolve conflicts?) looks like this had some patch you also sent separately. thanks

Hey John,

No problem and thanks for merging the other set!

moo_fury has been rebased against current master.

Cheers,
Fitz=

@SysPete
Copy link

SysPete commented May 11, 2015

Other Moose deps that need to be handled are Data::Visitor and replication (DBIC has Moose deps for this).
Data::Visitor deps can be handled using the ::Visitor class from recent DBIx::Class::Schema::PopulateMore - see: SysPete@159d1af
Replication tests just need to check for existence of relevant deps: SysPete@77efe3a
Maybe if this branch can be merged then I can create PRs for these other things?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants