Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix start span matchers slice flag #20

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Fix start span matchers slice flag #20

merged 1 commit into from
Apr 22, 2024

Conversation

jjti
Copy link
Owner

@jjti jjti commented Apr 22, 2024

Fixing this flag being set to an empty string:

# josh @ M-FTQC4VW0R3 in ~/jjti/go-spancheck/testdata/base on git:main o [19:12:04] 
$ spancheck ./...    
2024/04/22 19:12:10 [WARN] invalid start span signature "". expected regex:telemetry-type
/Users/josh/jjti/go-spancheck/testdata/base/base.go:22:2: span is unassigned, probable memory leak
/Users/josh/jjti/go-spancheck/testdata/base/base.go:23:7: span is unassigned, probable memory leak
/Users/josh/jjti/go-spancheck/testdata/base/base.go:28:2: span.End is not called on all paths, possible memory leak
/Users/josh/jjti/go-spancheck/testdata/base/base.go:30:1: return can be reached without calling span.End

@jjti jjti merged commit 1288474 into main Apr 22, 2024
3 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8792192493

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.942%

Totals Coverage Status
Change from base Build 8774900976: 0.0%
Covered Lines: 345
Relevant Lines: 411

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants