Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decaffeinate demo; fix sourcemaps #310

Merged
merged 7 commits into from
Jan 3, 2019
Merged

Decaffeinate demo; fix sourcemaps #310

merged 7 commits into from
Jan 3, 2019

Conversation

davidgoli
Copy link
Collaborator

@davidgoli davidgoli commented Dec 30, 2018

This removes the last of Coffeescript from the library entirely, converting the demo to Typescript.

It also converts the demo to rely on a Webpack build (the way a client app would in 2018) instead of direct-linking to the built rrule package via html.

This also addresses #303 .

@codecov-io
Copy link

codecov-io commented Dec 30, 2018

Codecov Report

Merging #310 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
- Coverage   89.91%   89.87%   -0.05%     
==========================================
  Files          28       28              
  Lines        1943     1945       +2     
  Branches      580      581       +1     
==========================================
+ Hits         1747     1748       +1     
- Misses        196      197       +1
Impacted Files Coverage Δ
src/iter/index.ts 98.11% <100%> (-0.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c839d54...fb5c2c7. Read the comment docs.

@davidgoli
Copy link
Collaborator Author

@AnthW I believe this addresses your sourcemap issue, would you please test this branch when you have a chance? Thanks!

@anthwinter
Copy link

@davidgoli I can confirm that this branch resolves the sourceMap issue. Thanks!

@davidgoli davidgoli merged commit a8974a2 into master Jan 3, 2019
@davidgoli davidgoli deleted the decaffeinate-demo branch January 3, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants