Simplify slicing #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It could be more elegant if right_bounds was positive, but then the slices for the Corrector would be uglier.
|
Thanks, and this looks great! Thanks for the edits |
jkeen
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I enjoyed reading your blog post about this gem!
I noticed when I looked at the code that the validation message for
left_boundswasn't quite right, and then I figured out a way to clean up those if statements.Edit: BTW, the rake task didn't work to run the specs for me. I installed the rspec-core binstub instead and ran that to make sure I didn't break your specs. Not sure why the rake wasn't behaving.