Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove asserts from precompile #23

Closed
wants to merge 1 commit into from

Conversation

timholy
Copy link
Collaborator

@timholy timholy commented Sep 5, 2021

This shouldn't be merged to master; instead, there should be a special branch created (e.g., release-0.4). However, since that branch doesn't exist I was unable to submit my pull request against it. So this may take a bit of manual work, sorry.

The motivation here is JuliaLang/julia#41447, CC @KristofferC, @vtjnash. Can we get a 0.4.2 release soon?

@jkrumbiegel
Copy link
Owner

I don't understand, why not master? Release 0.4.2 on a separate branch and then continue on without these changes on master?

@timholy
Copy link
Collaborator Author

timholy commented Sep 20, 2021

Right, these are needed to fix older releases of GridLayoutBase that still get used for package-compatibility reasons. master has already switched to @warnpcfail, so it doesn't need this change. (We could just delete @warnpcfail now, if you prefer, because Julia 1.7 will issue the warning automatically.)

So the steps are:

  • git checkout v0.4.1
  • git checkout -b release-0.4
  • git push origin release-0.4

Then this PR can be merged into release-0.4. Either I can resubmit it or you can do a local git merge, let me know what you prefer.

@timholy
Copy link
Collaborator Author

timholy commented Sep 20, 2021

One other tip: ideally you release 0.4.2 and then make a new 0.6.x release immediately thereafter. GitHub prints the "latest release" based on calendar date, not version number.

But that's just a secondary concern. Perhaps the more important thing to emphasize is that once Julia 1.7 comes out, anyone stuck for [compat] reasons on an older GridLayoutBase won't be able to build Makie unless you merge this and make this 0.4.2 release.

@timholy
Copy link
Collaborator Author

timholy commented Sep 29, 2021

Closed in favor of #24, which is against a new release-0.4 branch.

@timholy timholy closed this Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants