Skip to content

Commit

Permalink
Add a conformance test workflow
Browse files Browse the repository at this point in the history
* The conformance test suite is likely to still change quite a bit so
  the workflow is not enabled on PRs yet
* The actual conformance client is copied from the tuf-conformance project
* This is mostly a test to see how things should work out, and a
  demonstration of how the tuf-conformance project should be used

Signed-off-by: Jussi Kukkonen <[email protected]>
  • Loading branch information
jku committed Jul 10, 2024
1 parent 3947033 commit 3f49d7d
Show file tree
Hide file tree
Showing 4 changed files with 144 additions and 1 deletion.
124 changes: 124 additions & 0 deletions .github/scripts/conformance-client.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,124 @@
#!/usr/bin/env python
"""Conformance client for python-tuf, part of tuf-conformance"""

# Copyright 2024 tuf-conformance contributors
# SPDX-License-Identifier: MIT OR Apache-2.0

import argparse
import os
import shutil
import sys
from datetime import datetime, timedelta, timezone

from tuf.ngclient import Updater, UpdaterConfig

def init(metadata_dir: str, trusted_root: str) -> None:

Check failure on line 15 in .github/scripts/conformance-client.py

View workflow job for this annotation

GitHub Actions / test / Lint Test

Ruff (I001)

.github/scripts/conformance-client.py:7:1: I001 Import block is un-sorted or un-formatted
"""Initialize local trusted metadata"""

# No need to actually run python-tuf code at this point
shutil.copyfile(trusted_root, os.path.join(metadata_dir, "root.json"))
print(f"python-tuf test client: Initialized repository in {metadata_dir}")


def refresh(
metadata_url: str,
metadata_dir: str,
days_in_future: str,
max_root_rotations: int,
) -> None:
"""Refresh local metadata from remote"""

updater = Updater(
metadata_dir,
metadata_url,
config=UpdaterConfig(max_root_rotations=int(max_root_rotations)),
)
if days_in_future != "0":
day_int = int(days_in_future)
day_in_future = datetime.now(timezone.utc) + timedelta(days=day_int)
updater._trusted_set.reference_time = day_in_future # noqa: SLF001
updater.refresh()
print(f"python-tuf test client: Refreshed metadata in {metadata_dir}")


def download_target(
metadata_url: str,
metadata_dir: str,
target_name: str,
download_dir: str,
target_base_url: str,
) -> None:
"""Download target."""

updater = Updater(
metadata_dir,
metadata_url,
download_dir,
target_base_url,
config=UpdaterConfig(prefix_targets_with_hash=False),
)
target_info = updater.get_targetinfo(target_name)
if not target_info:
raise RuntimeError(f"{target_name} not found in repository")
updater.download_target(target_info)


def main() -> int:
"""Main TUF Client Example function"""

parser = argparse.ArgumentParser(description="TUF Client Example")
parser.add_argument("--metadata-url", required=False)
parser.add_argument("--metadata-dir", required=True)
parser.add_argument("--target-name", required=False)
parser.add_argument("--target-dir", required=False)
parser.add_argument("--target-base-url", required=False)
parser.add_argument("--days-in-future", required=False, default="0")
parser.add_argument(
"--max-root-rotations", required=False, default=32, type=int
)

sub_command = parser.add_subparsers(dest="sub_command")
init_parser = sub_command.add_parser(
"init",
help="Initialize client with given trusted root",
)
init_parser.add_argument("trusted_root")

sub_command.add_parser(
"refresh",
help="Refresh the client metadata",
)

sub_command.add_parser(
"download",
help="Downloads a target",
)

command_args = parser.parse_args()

# initialize the TUF Client Example infrastructure
if command_args.sub_command == "init":
init(command_args.metadata_dir, command_args.trusted_root)
elif command_args.sub_command == "refresh":
refresh(
command_args.metadata_url,
command_args.metadata_dir,
command_args.days_in_future,
command_args.max_root_rotations,
)
elif command_args.sub_command == "download":
download_target(
command_args.metadata_url,
command_args.metadata_dir,
command_args.target_name,
command_args.target_dir,
command_args.target_base_url,
)
else:
parser.print_help()

return 0


if __name__ == "__main__":
sys.exit(main())
16 changes: 16 additions & 0 deletions .github/workflows/conformance.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
on:
# manual dispatch only while the conformance test suite is under rapid development
workflow_dispatch:

name: CI
jobs:
conformance:
runs-on: ubuntu-latest
steps:
- name: Checkout the client wrapper
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7

- name: Run test suite
uses: theupdateframework/tuf-conformance@main
with:
entrypoint: ".github/scripts/conformance-client.py"
3 changes: 3 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,9 @@ ignore = [
"S603", # bandit: this flags all uses of subprocess.run as vulnerable
"T201", # print is ok in verify_release
]
".github/scripts/*" = [
"T201", # print is ok in conformance client
]

[tool.ruff.lint.flake8-annotations]
mypy-init-return = true
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ changedir = {toxinidir}
deps =
-r{toxinidir}/requirements/lint.txt
--editable {toxinidir}
lint_dirs = tuf examples tests verify_release
lint_dirs = tuf examples tests verify_release .github/scripts
passenv = RUFF_OUTPUT_FORMAT
commands =
ruff check {[testenv:lint]lint_dirs}
Expand Down

0 comments on commit 3f49d7d

Please sign in to comment.