-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to load scenes with custom properties #62
Conversation
Hey mate, thanks for your contribution,
|
Hey, Yessir, no problem I will go through the checklist ASAP and update the PR. Cheers |
Hey @jkvargas, I've made the changes you requested, just requesting a final review. I added an example usage for props in the examples folder :) Also, I'm a windows user atm, so I hope running the tests with PS: Very cool rust package, I'm glad to be able to contribute! Have a nice day! |
Thanks for the additions, man. |
Yea its a compilation error since the error[E0432]: unresolved imports `crate::sys::AI_CONFIG_IMPORT_COLLADA_IGNORE_UP_DIRECTION`, `crate::sys::AI_CONFIG_IMPORT_COLLADA_USE_COLLADA_NAMES`, `crate::sys::AI_CONFIG_IMPORT_FBX_PRESERVE_PIVOTS`, `crate::sys::AI_CONFIG_IMPORT_FBX_READ_WEIGHTS`, `crate::sys::AI_CONFIG_PP_OG_EXCLUDE_LIST`, `crate::sys::AI_CONFIG_PP_PTV_ADD_ROOT_TRANSFORMATION`, `crate::sys::AI_CONFIG_PP_PTV_ROOT_TRANSFORMATION`
--> src/property.rs:110:9
|
110 | AI_CONFIG_IMPORT_COLLADA_IGNORE_UP_DIRECTION, AI_CONFIG_IMPORT_COLLADA_USE_COLLADA_NAMES,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `AI_CONFIG_IMPORT_COLLADA_USE_COLLADA_NAMES` in the root
| |
| no `AI_CONFIG_IMPORT_COLLADA_IGNORE_UP_DIRECTION` in the root
111 | AI_CONFIG_IMPORT_FBX_PRESERVE_PIVOTS, AI_CONFIG_IMPORT_FBX_READ_WEIGHTS,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `AI_CONFIG_IMPORT_FBX_READ_WEIGHTS` in the root
| |
| no `AI_CONFIG_IMPORT_FBX_PRESERVE_PIVOTS` in the root
112 | AI_CONFIG_PP_OG_EXCLUDE_LIST, AI_CONFIG_PP_PTV_ADD_ROOT_TRANSFORMATION,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `AI_CONFIG_PP_PTV_ADD_ROOT_TRANSFORMATION` in the root
| |
| no `AI_CONFIG_PP_OG_EXCLUDE_LIST` in the root
113 | AI_CONFIG_PP_PTV_ROOT_TRANSFORMATION,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `AI_CONFIG_PP_PTV_ROOT_TRANSFORMATION` in the root
For more information about this error, try `rustc --explain E0432`.
error: could not compile `russimp` (lib test) due to previous error That's why I ran the tests with |
Hey man, I will disable the tests for now till I get a better understanding on what is going on. =) |
PropertyStore
struct to hold Assimp propertiesfrom_*_with_props
functions toScene
to load scenes with a property storeExample scene loading code