install: Don't require the network by default

The `Wants=network-online.target` predates the osmet work which enabled
the now default fully offline install flow.

It also predates the addition of fetch retries. So even in an online
flow, now that we retry HTTP requests indefinitely, we don't really
need this.

Let's follow best practices and stop pulling in `network-online.target`.

Still keep it as an `After` though; *if* something pulls in
`network-online.target`, then we might as well be nicer and start our
retries after we know we're online. Also add `network.target` so that
if `network-online.target` *isn't* pulled in, we still have a reasonable
lower bound on when we start retrying.

Related: coreos/fedora-coreos-config#1088
Related: coreos#565 (comment)
Related: https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/
Closes: https://github.com/coreos/coreos-installer/issues/1334

docs/release-notes.md

@@ -6,6 +6,22 @@ nav_order: 8
 
 ## Upcoming coreos-installer 0.19.0 (unreleased)
 
+Major changes:
+
+
+
+Minor changes:
+
+- install: Don't require the network by default
+
+Internal changes:
+
+
+
+Packaging changes:
+
+
+
 
 ## coreos-installer 0.18.0 (2023-08-24)
 

systemd/coreos-installer.service

@@ -1,8 +1,7 @@
 [Unit]
 Description=CoreOS Installer
 Before=coreos-installer.target
-After=network-online.target
-Wants=network-online.target
+After=network.target network-online.target
 # Until we retry HTTP requests let's wait here until
 # systemd-resolved comes up if enabled.
 # https://github.com/coreos/coreos-installer/issues/283