Fix pdf annotation extraction location error for some pdfs #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for looking into this. It’s really important that the pdf extraction gets updated. The Zotero team is actually working on integrating it into Zotero directly. Unfortunately, I can’t merge the pull request like this. The PDF format is very complex and maybe the two calls actually have a purpose but are just not important for this file. So I would have to figure out why they are there, which I don’t know without looking at the details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly fixes issues processing annotations of some PDFs.
I believe this solves #321. (I also tested with some of my other problematic PDFs)
The solution was to comment out two calls to the function makeAnnoDims. I do not fully understand the original intention of including them there, so I would appreciate if you could take a look.
Thank you!