Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tablet annotation behavior #482

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

yhmtsai
Copy link

@yhmtsai yhmtsai commented Aug 13, 2020

This mainly helps #226 .

image

image

  1. when disable rename file when send to ... and enable store copy of annotaion with suffix, the option Keep only one annotated file (detected by file)
  2. when enable keep only one annotation:
    • Send origin.pdf: get origin_suffix.pdf back (same as store copy)
    • Send origin_suffix.pdf: get origin_suffix.pdf by replacement (same as not store copy)
  3. Add menu item - Send Annotation to Tablet
    This will send the file which has most suffix in selecting files.
    For example,
    • item contains (A, A_suffix, A_suffix_suffix_suffix): only send A_suffix_suffix_suffix
    • select (A, A_suffix_suffix): only send A_suffix_suffix
    • select (A) : send A
      Note, Send Annotation to Tablet only consider the selecting files. Thus, even if there is A_suffix in the last example, it still send A to tablet because do not select A, A_suffix together. To avoid missing selection, suggest to apply Send Annotation to Tablet on item not files.

I am not entirely sure how to build the menu item. Some hint/comments are helpful.
Currently, I do not find a way to add Send Annotation to Tablet for subfolder.
Also, the text on de/it/fr are done by google translation.
All behavior depends on string, so it does not work on the inconsistent filename and different suffix (will be original behavior)

I am not familiar with javascript.
Also, I am a new user of Zotero, so I am not sure whether this behavior make sense for others.
any comment is welcome

@jlegewie
Copy link
Owner

Thanks for putting work into this. Unfortunately, I don't have time to review it right now. So it's going to remain as an open pull request for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants