Improve filename completer #203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leter cannot close quotes)
- provide flag to complete folders only - handles file and folders with blanks in name - allow suppressing final blank - allow completing folders instead of files - allow handling existing leading hyphens correctly (use same hyphen for completion end)
|
Actually juggling with opening and closing hyphens that way is really ugly. I think I'd rather redo the whole PR with escaping blanks instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #90, and adds a lot of tests and some features to FileNameCompleter. The code is much more complex than before, and I would not trust it without the number of tests I added. It is possible that the code could be refactored somewhat, to save a few lines, in particular handling of closing hyphens with folders is ugly, as I though of it rather late. I will wait for feedback before spending more time on that.
The basic problem is when completing
The completer needs to take into account plenty of things, like:
file with blank.txtexist that needs to be hyphenated'file with blank.txt'?file.txt"?Depending on the context, the completion should be different.
To merge, also consider this:
I did not test the changes on other operating systems than Linux.
The small commits fixing minor stuff could be merged early, if you like.