Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing into i-search sometimes toggles showing results every other char #244

Closed
bdw429s opened this issue Mar 28, 2018 · 2 comments
Closed
Milestone

Comments

@bdw429s
Copy link
Contributor

bdw429s commented Mar 28, 2018

I haven't found out exactly why this doesn't happen every single time, but I'm very commonly seeing a behavior where filtering my i-search while typing a word that is an exact match for an item in my history toggles the result on and off meaning it only shows up every other character.

For instance, I have a history item that is the word "history". Right now if I press Ctrl-S and starting typing, here is the result:

  • I type "h" --> the match "history" is displayed
  • I add an "i' for "hi" --> the results disappear and nothing is matched
  • I add an "s" for "his" --> the match "history" is displayed again
  • I add a "t" for "hist" --> the results disappear and nothing is matched
  • I add an "o" for "histo" --> the match "history" is displayed again
  • I add a "r" for "histor" --> the results disappear and nothing is matched
  • I add a "y" for "history" --> the match "history" is displayed again

I think it has to do with only having a single matching line in my history. Try clearing your history and only adding a few unique test lines to try this.

gnodet added a commit that referenced this issue Apr 3, 2018
@gnodet
Copy link
Member

gnodet commented Apr 3, 2018

Hopefuly this is fixed with the rewrite of i-search.

@gnodet gnodet closed this as completed Apr 3, 2018
@bdw429s
Copy link
Contributor Author

bdw429s commented Apr 3, 2018

Thanks @gnodet , I'll give it a test.

@gnodet gnodet added this to the 3.7.0 milestone Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants