Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain characters not working on Czech QWERTY keyboard #747

Closed
lahodaj opened this issue Nov 18, 2021 · 1 comment
Closed

Certain characters not working on Czech QWERTY keyboard #747

lahodaj opened this issue Nov 18, 2021 · 1 comment
Labels
Milestone

Comments

@lahodaj
Copy link
Contributor

lahodaj commented Nov 18, 2021

Some characters, like '{' cannot be typed (and a bit surprisingly not even pasted) on Czech QWERTY keyboard. These characters are input using AltGr+Shift. Looking at the code here:

&& (controlKeyState & (RIGHT_ALT_PRESSED | LEFT_ALT_PRESSED | RIGHT_CTRL_PRESSED | LEFT_CTRL_PRESSED | SHIFT_PRESSED))

the code tries to detect AltGr, but it also checks that Shift is not pressed, so doing AltGr+Shift+{ is failing the check, and the character is not typed. If I remove the | SHIFT_PRESSED from the test, I can type the characters fine.

Is there a need for the test to include Shift? Will removing the Shift check break something?

Thanks!

This was originally reported for OpenJDK:
https://bugs.openjdk.java.net/browse/JDK-8272139

@gnodet gnodet added the bug label May 31, 2022
@gnodet
Copy link
Member

gnodet commented Jun 3, 2022

I don't really see any problem in removing the check for the SHIFT key. Would you mind raising a PR for that ?

@gnodet gnodet added this to the 3.23.0 milestone Mar 6, 2023
gnodet added a commit to gnodet/jline3 that referenced this issue Mar 6, 2023
@gnodet gnodet closed this as completed in 63618cc Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants