Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove_pairings over IP uses wrong Content-Type header #188

Closed
An00bIS47 opened this issue Apr 24, 2020 · 3 comments
Closed

remove_pairings over IP uses wrong Content-Type header #188

An00bIS47 opened this issue Apr 24, 2020 · 3 comments
Assignees
@jlusiardi
Labels
bug

Comments

@An00bIS47
Copy link

Hi,

when removing pairings over IP, a wrong Content-Type header is used. It seems to use application/hap+json.

POST /pairings HTTP/1.1
Host: ...
Content-Type: application/hap+json
Content-Length: 44

=== [bodyData] (len:44) ===
06 01 01 00 01 04 ...
======

The HomeKit documentation state the following on page 48

The MIME type for requests and responses is application/pairing+tlv8.
@jlusiardi jlusiardi self-assigned this Apr 25, 2020
@jlusiardi jlusiardi added the bug label Apr 25, 2020
jlusiardi added a commit that referenced this issue Apr 25, 2020
@jlusiardi
Fix for #188: remove_pairing uses wrong content-type
67aaa95 
Fix the issue and add test capabilities to verify no wrong
content type header was used.
@jlusiardi
Copy link
Owner

should be fixed with #191, just waiting for the tests

jlusiardi added a commit that referenced this issue Apr 25, 2020
@jlusiardi
Fix for #188: remove_pairing uses wrong content-type (#191)
4feade9 
Fix the issue and add test capabilities to verify no wrong
content type header was used.
@An00bIS47
Copy link
Author

Wow. That was fast :) Thanks for that

I can verify, that the changes worked.

POST /pairings HTTP/1.1
Host: ...
Content-Type: application/pairing+tlv8
Content-Length: 44


=== [bodyData] (len:44) ===
06 01 01 00 01 04 ...

@jlusiardi
Copy link
Owner

Cool thanks for your report & confirmation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jlusiardi jlusiardi

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@An00bIS47 @jlusiardi