Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLE-Controller: RequestRejected not correctly initialized #232

Open
kvaellning opened this issue Feb 28, 2022 · 1 comment
Open

BLE-Controller: RequestRejected not correctly initialized #232

kvaellning opened this issue Feb 28, 2022 · 1 comment

Comments

@kvaellning
Copy link

Implementation of RequestRejected soed not pass "self" to the exception initialization, thus leading to an error on construction.

I think it would be good to refactor the errors so that they are using super().__init__(message)-syntax instead of Exception.__init__(message)
@kvaellning
Copy link
Author

There's actually a little bit more wrong here, since it uses an error_code argument instead of the more widely used status, which is also referenced in the handling.

kvaellning pushed a commit to kvaellning/homekit_python that referenced this issue Feb 28, 2022
fix: initialization of RequestRejected-error
14d6d36 
see issue jlusiardi#232
kvaellning pushed a commit to kvaellning/homekit_python that referenced this issue Feb 28, 2022
fix: replace error_code with status
2ba289c 
The BLE-implementation tries to access the field "status", not the field
"error_code". This change brings RequestRejected more inline with the other
exception definitions.

see issue jlusiardi#232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kvaellning