Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BlePairing::_convert_from_python produces errors with TLVs #238

Open
kvaellning opened this issue Apr 11, 2022 · 0 comments
Open

BlePairing::_convert_from_python produces errors with TLVs #238

kvaellning opened this issue Apr 11, 2022 · 0 comments

Comments

@kvaellning
Copy link

I am sending TLV-data to an accessory. Eversthing appears to go well, until I reach BlePairing::_convert_from_python (controller/ble_impl__init__.py:255), which

  1. translates an already encoded value to a hex string,
  2. re-encodes it to bytes

This destroys the TLV, and I have no idea why this is done.
I would treat this as an issue, since it is totally unexpected and only found it after meditating over the debug outputs.
kvaellning pushed a commit to kvaellning/homekit_python that referenced this issue Apr 11, 2022
Do not create hex-string and rebuild byte string for TLV and data
bd970b1 
Since TLVs (and data) are defined on byte level, the values are destroyed
by converting them to string and back to bytes.

This solves issue jlusiardi#238.
@kvaellning kvaellning mentioned this issue Apr 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kvaellning