Updated fork for python-3 compatibility. #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sphinx needed an upgrade in order to build on py3. Also upgraded the other dependencies to modern versions so we pull in the latest bugfixes.
jamesls
approved these changes
May 25, 2022
There was a problem hiding this comment.
Looks good! I had to bump the version of Sphinx in the requirements.txt file otherwise I was getting this error on py3.9:
$ make html
/Library/Developer/CommandLineTools/usr/bin/make -C docs/ html
sphinx-build -b html -d _build/doctrees . _build/html
Running Sphinx v1.2.2
loading pickled environment... failed: env version not current
Exception occurred:
File "/Users/jamessar/.virtualenvs/tmp-d018bd311cd3cc8/lib/python3.9/site-packages/sphinx/jinja2glue.py", line 15, in <module>
from jinja2 import FileSystemLoader, BaseLoader, TemplateNotFound, \
ImportError: cannot import name 'contextfunction' from 'jinja2'
Also went ahead and bumped the other packages to more recent versions so we pull in the latest bug fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
#95