Skip to content

Commit

Permalink
feat: Allow 'both' option for uibannerposition (argoproj#14623)
Browse files Browse the repository at this point in the history 
* fix(ui): Drop ready from Completed container status (#14434) (#14629)

Signed-off-by: schakrad <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore(deps): bump github.com/go-git/go-git/v5 from 5.7.0 to 5.8.0 (#14641)

Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.7.0 to 5.8.0.
- [Release notes](https://github.com/go-git/go-git/releases)
- [Commits](https://github.com/go-git/go-git/compare/v5.7.0...v5.8.0)

---
updated-dependencies:
- dependency-name: github.com/go-git/go-git/v5
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jimmy Neville <[email protected]>

* fix: webhook handler fails to refresh when alternate application namespaces are configured (#13976)

* fix: Add failing test for webhooks in all namespaces

This adds a failing test that properly exercises this functionality over
all namespaces. The issue with the code that is under test is that it
does not pass the namespace correctly to the patch of the application,
resulting in the patch not taking place in the correct namespace

Signed-off-by: Nikolas Skoufis <[email protected]>

* fix: queue webhook refresh for apps in all namespaces

This passes the test in the previous commit, to ensure that webhooks
correctly refresh applications across all namespaces.

Signed-off-by: Nikolas Skoufis <[email protected]>

* fix: Use existing NamespacedName type

Use the existing type instead of a custom type

Signed-off-by: Nikolas Skoufis <[email protected]>

---------

Signed-off-by: Nikolas Skoufis <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix: ApplicationSet Controller crashes when tag is not closed; panic: Cannot find end tag="}}"(#14227) (#14651)

* ApplicationSet bug fix

Signed-off-by: schakrad <[email protected]>

* Update applicationset/utils/utils_test.go

Signed-off-by: Michael Crenshaw <[email protected]>

* oops

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: schakrad <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix(ui): The default pod group filter should be removed if fewer than 15 pods (#14590)

Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* feat(deep-links): sprig support (#14660)

Signed-off-by: daftping <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: Print in-cluster svr addr disabled warning when server starts (#14553)

* chore: Print in-cluster svr addr disabled warning when server starts

Signed-off-by: Yuan Tang <[email protected]>

* fix: mock

Signed-off-by: Yuan Tang <[email protected]>

* no interface change

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Yuan Tang <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: Upgrade semver to avoid cve (#14710)

Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* feat: adding a autosync_enabled field  to the argocd_app_info gauge (#14424)

Signed-off-by: Gerardo Corea <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix(controller): log failed attempts to update operation state (#14273)

* fix(controller): log failed attempts to update operation state

Signed-off-by: Michael Crenshaw <[email protected]>

* new package name

Signed-off-by: Michael Crenshaw <[email protected]>

* Update controller/appcontroller_test.go

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix(server): handle PATCH in http/s server (#2677) (#14530)

Signed-off-by: mmerrill3 <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix: manifest generation error with null annotations (#14336) (#14680)

* fix: manifest generation error with null annotations

Signed-off-by: Alexandre Gaudreault <[email protected]>

* fix test

Signed-off-by: Alexandre Gaudreault <[email protected]>

* fix unit tests

Signed-off-by: Alexandre Gaudreault <[email protected]>

---------

Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* Clean up repeated package import (#13889)

Signed-off-by: Zechun Chen <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix(sso): Set redirectURI for gitea, google, oauth Dex connectors (#11237)

Signed-off-by: ylxianzhe <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* feat(appset): Restrict scm provider urls (#14286)

* 9353: Restrict scm provider urls

Signed-off-by: gmuselli <[email protected]>

* 9353: Enforce restriction

Signed-off-by: gmuselli <[email protected]>

* 9353: Fix after review

Signed-off-by: gmuselli <[email protected]>

* 9353: Remove comment

Signed-off-by: gmuselli <[email protected]>

* 9353: Fix units tests

Signed-off-by: Geoffrey Muselli <[email protected]>

* 9353: Code review, update comment

Signed-off-by: gmuselli <[email protected]>

* 9353: Code review, update comment 2

Signed-off-by: gmuselli <[email protected]>

* 9353: Remove doc issues

Signed-off-by: gmuselli <[email protected]>

* 9353: Fix e2e

Signed-off-by: gmuselli <[email protected]>

* 9353: Fix e2e goTemplate

Signed-off-by: gmuselli <[email protected]>

* 9353: Fix e2e pullRequestGenerator

Signed-off-by: gmuselli <[email protected]>

---------

Signed-off-by: gmuselli <[email protected]>
Signed-off-by: Geoffrey Muselli <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore(deps): bump github.com/go-git/go-git/v5 from 5.8.0 to 5.8.1 (#14744)

Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.8.0 to 5.8.1.
- [Release notes](https://github.com/go-git/go-git/releases)
- [Commits](https://github.com/go-git/go-git/compare/v5.8.0...v5.8.1)

---
updated-dependencies:
- dependency-name: github.com/go-git/go-git/v5
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jimmy Neville <[email protected]>

* chore(deps): bump github.com/aws/aws-sdk-go from 1.44.305 to 1.44.309 (#14746)

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.305 to 1.44.309.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.305...v1.44.309)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jimmy Neville <[email protected]>

* fix(ui): display valuesobject if set (#14257)

* fix: display valuesobject if set

With #11538 we now have the ability to set helm values as an object
instead of a string, but we also need to be able to correctly display
it in the UI if it is set.

Signed-off-by: Blake Pettersson <[email protected]>

* fix: set valuesobject on save

If `valuesObject` is present, set it to the value of
`input.spec.source.helm.values` on save, as an unmarshaled json string.

Signed-off-by: Blake Pettersson <[email protected]>

* fix: set `helm.values` to empty string on save

If `valuesObject` exists, set `input.spec.source.helm.values` to an
empty string once `valuesObject` has been unmarshalled from the
values input. This is to prevent unnecessary duplication of the values.

Signed-off-by: Blake Pettersson <[email protected]>

* chore: eslint

Signed-off-by: Blake Pettersson <[email protected]>

* chore: eslint

Signed-off-by: Blake Pettersson <[email protected]>

* fix: deep clone app

This is so that we can conditionally set `source.helm.values` without
inadvertently affecting other parts of the app. Only when the edit
button is pressed do we toggle `source.helm.values`.

Signed-off-by: Blake Pettersson <[email protected]>

* chore: eslint

Signed-off-by: Blake Pettersson <[email protected]>

---------

Signed-off-by: Blake Pettersson <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix: OCI dependency url can't contain part of repository (#14699)

Signed-off-by: Alexander Matyushentsev <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* docs: Add missing value (#14538)

Signed-off-by: felix <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* [Bot] docs: Update Snyk reports (#14781)

Signed-off-by: CI <[email protected]>
Co-authored-by: CI <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore(deps): bump github.com/aws/aws-sdk-go from 1.44.309 to 1.44.312 (#14782)

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.309 to 1.44.312.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.309...v1.44.312)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jimmy Neville <[email protected]>

* chore(deps): bump github.com/xanzy/go-gitlab from 0.88.0 to 0.89.0 (#14784)

Bumps [github.com/xanzy/go-gitlab](https://github.com/xanzy/go-gitlab) from 0.88.0 to 0.89.0.
- [Changelog](https://github.com/xanzy/go-gitlab/blob/master/releases_test.go)
- [Commits](https://github.com/xanzy/go-gitlab/compare/v0.88.0...v0.89.0)

---
updated-dependencies:
- dependency-name: github.com/xanzy/go-gitlab
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jimmy Neville <[email protected]>

* chore(deps): bump github.com/casbin/casbin/v2 from 2.72.1 to 2.73.0 (#14783)

Bumps [github.com/casbin/casbin/v2](https://github.com/casbin/casbin) from 2.72.1 to 2.73.0.
- [Release notes](https://github.com/casbin/casbin/releases)
- [Changelog](https://github.com/casbin/casbin/blob/master/.releaserc.json)
- [Commits](https://github.com/casbin/casbin/compare/v2.72.1...v2.73.0)

---
updated-dependencies:
- dependency-name: github.com/casbin/casbin/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: add Autodesk to USERS.md (#14778)

Signed-off-by: Dylan Page <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: Add query-scoped cluster URL in Cluster Secret E2E tests (#14446)

* Add query-scoped cluster URL in Cluster Secret E2E tests

Signed-off-by: Jonathan West <[email protected]>

* Respond to review comments

Signed-off-by: Jonathan West <[email protected]>

---------

Signed-off-by: Jonathan West <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* docs: Clarify that security policy covers last 3 versions (#14786)

* docs: Clarify that security policy covers last 3 versions

Signed-off-by: Kostis Kapelonis <[email protected]>

* Update SECURITY.md

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Kostis Kapelonis <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix(controller): cache deadlock on delete and re-add cluster (#14780)

Signed-off-by: Nathan Romriell <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: make `helm template` errors less verbose (#14772)

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* feat(deep-links): alias `application` as `apps` for consistency with notifications engine (#14761)

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix(ui): no hyphen for "create job" action + nice icon (#14776) (#14777)

* chore(actions): space instead of hyphen in action name (#14776)

Signed-off-by: Michael Crenshaw <[email protected]>

* new field for backwards-compatibility

Signed-off-by: Michael Crenshaw <[email protected]>

* align icons for maximum synergy

Signed-off-by: Michael Crenshaw <[email protected]>

* delete unused function

Signed-off-by: Michael Crenshaw <[email protected]>

* revert unnecessary changes

Signed-off-by: Michael Crenshaw <[email protected]>

* Update docs/operator-manual/upgrading/2.7-2.8.md

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix: Correct broken `forever` option in pod logs viewer. Fixes #14762 (#14763)

Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* docs: Update application.yaml (#14742)

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* docs: add ignoreDifferences name and namespace fields (#14741)

* Update application.yaml

Signed-off-by: Michael Crenshaw <[email protected]>

* Update docs/operator-manual/application.yaml

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore(deps): bump library/node from 20.4.0 to 20.5.0 (#14664)

Bumps library/node from 20.4.0 to 20.5.0.

---
updated-dependencies:
- dependency-name: library/node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jimmy Neville <[email protected]>

* chore(deps): bump library/node from 20.4.0 to 20.5.0 in /ui-test (#14662)

Bumps library/node from 20.4.0 to 20.5.0.

---
updated-dependencies:
- dependency-name: library/node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jimmy Neville <[email protected]>

* docs: Update Controlling-Resource-Modification.md (#14751)

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix(notifications-catalog): Add nil check for notifications_catalog triggers (#14795)

* Add nil check for notifications_catalog triggers

Signed-off-by: Trung <[email protected]>

* Use correct nil check

Signed-off-by: Trung <[email protected]>

* Add missing catalog generation to makefile

Signed-off-by: Trung <[email protected]>

* Revert changes to update-manifests.sh

Signed-off-by: Trung <[email protected]>

---------

Signed-off-by: Trung <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix: ManagedResources API should not return diff for hooks (#14816)

Signed-off-by: Alexander Matyushentsev <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* docs: Change Generator docs for List Generator to note any key/value pairs can be used (#14825)

This is no longer limited to cluster/url value pairs.

Signed-off-by: JesseBot <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: improve app destination docstrings (#14836)

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* feat: Adding kubelogin capability to argocd-k8s-auth (#9460) (#10700)

Signed-off-by: mmerrill3 <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: Add header support for proxy extension requests  (#14800)

* chore: add server URL in the header of proxy extensions

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* feat: add header support for proxy extension requests

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* Address review comments

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* address review comments

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* Address review comments

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* Address review comments

Signed-off-by: Leonardo Luz Almeida <[email protected]>

---------

Signed-off-by: Leonardo Luz Almeida <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* docs: use consistent password in plugin generator examples (#14837)

* docs: use consistent password in plugin generator examples

The example secret with the token is using `strong-password`, but the later examples use `string-password`.

This updates all of the examples to use `strong-password`.

Signed-off-by: Nicholas Morey <[email protected]>

* docs: update another-secret example to include `strong-password`

Consistent with above example of client token in argocd-secret

Signed-off-by: Nicholas Morey <[email protected]>

---------

Signed-off-by: Nicholas Morey <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: give context to error logs #10592 (#14851)

* chore: give context to error logs

Signed-off-by: ashinsabu3 <[email protected]>

* Update reposerver/repository/repository.go

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: ashinsabu3 <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: add more tests in proxy extension headers (#14842)

Signed-off-by: Leonardo Luz Almeida <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: revert #12255 (#14858)

This reverts commit c651bd8de551c85fc897c997c1976d6777259921.

Due to the imminent release of 2.8, this needs to be rolled back since
the proposed fix in #14210 cannot make it in time.

Signed-off-by: Blake Pettersson <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix: Repo URL link for unsupported sources links to https://<argocd>/null/path/to/chart (#14861)

* Fix #14860

Fix #14860

Signed-off-by: Talia Stocks <[email protected]>

* Update USERS.md

Signed-off-by: Talia Stocks <[email protected]>

---------

Signed-off-by: Talia Stocks <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix: correct discrepancies in generated swagger file (#14813)

Signed-off-by: Alexander Matyushentsev <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: wrap ComparisonError messages (#14886)

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix(ui): Fixes health icon positioning (#14708) (#14852)

* fix: Fixes health icon positioning #14708

Signed-off-by: ashinsabu3 <[email protected]>

* fix: Fixes alignment of app health application status panel #14708

Signed-off-by: ashinsabu3 <[email protected]>

* fix: Added line height to App Status to fix its  positioning #14708

Signed-off-by: ashinsabu3 <[email protected]>

---------

Signed-off-by: ashinsabu3 <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: fix non-deterministic test (#14905)

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix: Change underscore (_) back to plus (+) to get valid SemVer when when reading tags from OCI registry (#14537)

* fix: Change underscore (_) back to plus (+) to get valid SemVer when reading tags from OCI registry

Signed-off-by: xashr <[email protected]>

* Add test coverage for SemVer tags in TestGetTagsFromUrl

Signed-off-by: xashr <[email protected]>

---------

Signed-off-by: xashr <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix(appset): typo in ARGOCD_APPLICATIONSET_CONTROLLER_ALLOWED_SCM_PROVIDERS (#14902) (#14913)

Signed-off-by: gmuselli <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* feat: provide short revision in ARGOCD_APP_REVISION_SHORT env variable (#14926)

Signed-off-by: Alexander Matyushentsev <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore(deps): bump github.com/aws/aws-sdk-go from 1.44.312 to 1.44.317 (#14925)

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.312 to 1.44.317.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.312...v1.44.317)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jimmy Neville <[email protected]>

* chore(deps): bump golang.org/x/oauth2 from 0.10.0 to 0.11.0 (#14922)

Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.10.0 to 0.11.0.
- [Commits](https://github.com/golang/oauth2/compare/v0.10.0...v0.11.0)

---
updated-dependencies:
- dependency-name: golang.org/x/oauth2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jimmy Neville <[email protected]>

* docs: Update Generators-Git.md (#14921)

Remove a misleading symbol from the pattern for the path.Match function. The pipe symbol doesn't have any special meaning.

Signed-off-by: German Lashevich <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* docs: Update helm.md - add missing syntax highlighting for YAML and Dockerfile blocks (#14911)

Signed-off-by: JesseBot <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix(ui): COPY JSON for ArgoCD version should include trailing newline (#5117) (#14917)

Signed-off-by: Vipin M S <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* [Bot] docs: Update Snyk reports (#14919)

Signed-off-by: CI <[email protected]>
Co-authored-by: CI <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: give context to error logs (#10592) (#14915)

* chore: wrap error objects to include context

Signed-off-by: Vipin M S <[email protected]>

* chore: wrap error objects to include context

Signed-off-by: Vipin M S <[email protected]>

* chore: wrap error objects to include context

Signed-off-by: Vipin M S <[email protected]>

* chore: wrap error objects to include context

Signed-off-by: Vipin M S <[email protected]>

* Update applicationset/controllers/applicationset_controller.go

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Vipin M S <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* feat(appset): Add SCM Provider option for Gitlab generator to filter shared projects from subgroups projects (#14831)

* added option to disable gitlab to fetch shared project from a subgroup

Signed-off-by: Prune <[email protected]>

* Correct gitlab SCM provider mock test

Signed-off-by: Prune <[email protected]>

* updated test to validate shared-groups

Signed-off-by: Prune <[email protected]>

* reworked shared project tests

Signed-off-by: Prune <[email protected]>

* added subgroups only test

Signed-off-by: Prune <[email protected]>

---------

Signed-off-by: Prune <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix(cmp): send sigterm to cmp commands before sigkill to allow for potential cleanup (#9180) (#14955)

* fix: send sigterm to cmp commands before sigkill to allow for potential cleanup

Signed-off-by: Ashin Sabu <[email protected]>

* fix: unit test for runCommand in cmpserver to test cleanup modified

Signed-off-by: Ashin Sabu <[email protected]>

* fix: change unit test for plugin/runCommand to avoid bad trap along with lint fix

Signed-off-by: Ashin Sabu <[email protected]>

---------

Signed-off-by: Ashin Sabu <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* docs: Feature bounty proposal (Experimental) (#14234)

* Create bounty proposal

Signed-off-by: Dan Garfield <[email protected]>

* Update docs/proposals/feature-bounties.md

Signed-off-by: Dan Garfield <[email protected]>

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Dan Garfield <[email protected]>

* Update docs/proposals/feature-bounties.md

Signed-off-by: Dan Garfield <[email protected]>

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Dan Garfield <[email protected]>

* Update docs/proposals/feature-bounties.md

Signed-off-by: Dan Garfield <[email protected]>

* Update docs/proposals/feature-bounties.md

Signed-off-by: Michael Crenshaw <[email protected]>

* Update docs/proposals/feature-bounties.md

Signed-off-by: Dan Garfield <[email protected]>

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Dan Garfield <[email protected]>

* Update docs/proposals/feature-bounties.md

Signed-off-by: Dan Garfield <[email protected]>

* Update docs/proposals/feature-bounties.md

Signed-off-by: Dan Garfield <[email protected]>

---------

Signed-off-by: Dan Garfield <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix(actions): check if CronWorkflow has labels in create-workflow action (#14962) (#14974)

Signed-off-by: Mickaël Canévet <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: add Jellysmack in USERS.md (#14975)

Signed-off-by: Mickaël Canévet <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore(deps): bump actions/setup-go from 4.0.1 to 4.1.0 (#14970)

Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4.0.1 to 4.1.0.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](https://github.com/actions/setup-go/compare/fac708d6674e30b6ba41289acaab6d4b75aa0753...93397bea11091df50f3d7e59dc26a7711a8bcfbe)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jimmy Neville <[email protected]>

* docs: Adding native OCI support proposal (#13516)

Signed-off-by: Andrew Block <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: space in 'Argo CD' (#14987)

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* feat: Add Support for AzureDevops Webhooks (#14969)

* feat: Add Support for AzureDevops Webhooks

Signed-off-by: Alexander Matyushentsev <[email protected]>

* document azure devops webhook configuration

Signed-off-by: Alexander Matyushentsev <[email protected]>

---------

Signed-off-by: Alexander Matyushentsev <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix: api server fails to call dex with istio (#14995)

Signed-off-by: Alexander Matyushentsev <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix(ui): Update default and max count for maxCookieNumber (#14979)

* Update default and max count for maxCookieNumber

Signed-off-by: zvlb <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix: correct the swagger ui link to support --rootpath (#14845)

Signed-off-by: Kevin Yue <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore(deps): upgrade nhooyr.io/websocket dependency (#15000)

Upgrade from 1.8.6 to 1.8.7 due to high security issue

Was solved in dependency with https://github.com/nhooyr/websocket/pull/291

Signed-off-by: jmeridth <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: upgrade to go 1.21 (#14992)

Signed-off-by: Robin Lieb <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore(deps): bump goreleaser/goreleaser-action from 4.3.0 to 4.4.0 (#14996)

Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 4.3.0 to 4.4.0.
- [Release notes](https://github.com/goreleaser/goreleaser-action/releases)
- [Commits](https://github.com/goreleaser/goreleaser-action/compare/336e29918d653399e599bfca99fadc1d7ffbc9f7...3fa32b8bb5620a2c1afe798654bbad59f9da4906)

---
updated-dependencies:
- dependency-name: goreleaser/goreleaser-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jimmy Neville <[email protected]>

* fix: bump ubuntu base image (#15020) (#15021)

Latest version of the ubuntu image addresses CVE-2023-38408.

https://ubuntu.com/security/notices/USN-6242-1
https://github.com/docker-library/repo-info/blob/master/repos/ubuntu/remote/22.04.md

resolves #15020

Signed-off-by: Mason Cole <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: give context to errors (#10592) (#15022)

* chore: give context to errors

Signed-off-by: Vipin M S <[email protected]>

* Update util/settings/settings.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Vipin M S <[email protected]>

* Update util/settings/settings.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Vipin M S <[email protected]>

* Update util/tls/tls.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Vipin M S <[email protected]>

* Update util/settings/settings.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Vipin M S <[email protected]>

* Update util/settings/settings.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Vipin M S <[email protected]>

* Update util/settings/settings.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Vipin M S <[email protected]>

* Update util/settings/settings.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Vipin M S <[email protected]>

* Update util/settings/settings.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Vipin M S <[email protected]>

* Update util/tls/tls.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Vipin M S <[email protected]>

* Update util/tls/tls.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Vipin M S <[email protected]>

* Apply suggestions from code review

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Vipin M S <[email protected]>
Signed-off-by: Vipin M S <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: give context to errors (#15019)

* chore: give context to error logs in reposerver

Signed-off-by: Ashin Sabu <[email protected]>

* chore: give context to errors in applicationset

Signed-off-by: Ashin Sabu <[email protected]>

* chore: give context to errors(tweaks in error messages)

Signed-off-by: Ashin Sabu <[email protected]>

* chore: give context to errors(fix unit test)

Signed-off-by: Ashin Sabu <[email protected]>

---------

Signed-off-by: Ashin Sabu <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: add Carrefour Group to USERS.md (#15039)

Signed-off-by: Zadkiel Aharonian <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix(health): spec.executor.instances is Optional, Support a flexible number of executors (#11877)

Support a flexible number of executors. For example with a mounted ConfigMap inside the Spark-Operator.

Signed-off-by: Philipp Dallig <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* [Bot] docs: Update Snyk reports (#15031)

Signed-off-by: CI <[email protected]>
Co-authored-by: CI <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix(reposerver): loosen source not permitted helm errors (#14210)

* fix: loosen source not permitted helm errors

With #12255, we check if a source is first permitted before running
`helm template`. This works a bit too well, since this may break
previously working manifests. If an `AppProject` has a set of
`sourceRepos` which are more restrictive than `*`, and it also has Helm
public dependencies (repos with credentials would not work with 2.7x
due to the fact they get filtered out before ending up on the repo
server). Whereas before this would work, this currently fails on
`HEAD` but not in `2.7x`.

What we instead do here is that we only run this check if the chart
failed to download - if it does then we run a check to see if the repo
is in the allowed repos list. If the repo is not in the allowed repos
list, we return the same error as in #12555, otherwise we bubble up the
error.

Should fix #13833.

Signed-off-by: Blake Pettersson <[email protected]>

* fix: check for 401 unauthorized in error

The regex check works fine for OCI artifacts, but the flow is slightly
different for standard Helm charts (specifically when running
`helm repo add`). To get around that, we also check the error for
`401 Unauthorized`.

Signed-off-by: Blake Pettersson <[email protected]>

* fix: loosen string check

Signed-off-by: Blake Pettersson <[email protected]>

* Revert "chore: revert #12255 (#14858)"

This reverts commit c8ae5bc3e79fa985632861f75669c07523f5ded6.

Signed-off-by: Blake Pettersson <[email protected]>

* wip

Signed-off-by: Blake Pettersson <[email protected]>

* wip

Signed-off-by: Blake Pettersson <[email protected]>

* chore: reword test to reduce confusion

Signed-off-by: Blake Pettersson <[email protected]>

---------

Signed-off-by: Blake Pettersson <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix(appset): Fix helm valuesObject with ApplicationSet (#14912) (#14920)

Signed-off-by: Geoffrey Muselli <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* feat(cli): support apply out of sync flag only (#14624)

* feat: support apply out of sync flag only

Signed-off-by: pashakostohrys <[email protected]>

* update engine version

Signed-off-by: pashakostohrys <[email protected]>

* update gitops engine version

Signed-off-by: pashakostohrys <[email protected]>

* add cli option

Signed-off-by: pashakostohrys <[email protected]>

* feat: verify apply out of sync flag

Signed-off-by: pashakostohrys <[email protected]>

* redundant comment

Signed-off-by: pashakostohrys <[email protected]>

* improve test logic

Signed-off-by: pashakostohrys <[email protected]>

* change command description and do codegen

Signed-off-by: pashakostohrys <[email protected]>

---------

Signed-off-by: pashakostohrys <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* docs(github): comment out notational pieces of PR template (#14888)

- the DCO and FAQ sentences are not filled out during PRs and are purely notational
  - comment them out with HTML comments, as is common practice
    - example from argo-helm: https://github.com/argoproj/argo-helm/blob/962342fe2acef6022ac5c1a3eb352b336308b3eb/.github/pull_request_template.md?plain=1#L1
      - copied this practice from other repos I maintain and from other repos before that
- these comments are still visible to the PR author, just not visible when rendered, keeping the PR more concise

Signed-off-by: Anton Gilgur <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore(deps): bump golangci/golangci-lint-action from 3.6.0 to 3.7.0 (#15053)

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.6.0 to 3.7.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](https://github.com/golangci/golangci-lint-action/compare/639cd343e1d3b897ff35927a75193d57cfcba299...3a919529898de77ec3da873e3063ca4b10e7f5cc)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jimmy Neville <[email protected]>

* chore(deps): bump actions/setup-node from 3.7.0 to 3.8.0 (#15054)

Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.7.0 to 3.8.0.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](https://github.com/actions/setup-node/compare/e33196f7422957bea03ed53f6fbb155025ffc7b8...bea5baf987ba7aa777a8a0b4ace377a21c45c381)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jimmy Neville <[email protected]>

* docs: Update bank vaults link to point to the new org (#15069)

Bank-Vaults recently migrated to a new organization. The old repository is archived.

Signed-off-by: Anton Lindholm <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: improve error logs (#10592) (#15059)

* chore: improve error logs

Signed-off-by: AvhiMaz <[email protected]>

* chore: Changes made according to the reviewer

Signed-off-by: AvhiMaz <[email protected]>

* chore: Chnages according to the reviewerI"

Signed-off-by: AvhiMaz <[email protected]>

* Update cmpserver/apiclient/plugin.pb.go

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: AvhiMaz <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* docs: Update link to KubeCon China 2021 talk in README.md (#14887)

Signed-off-by: Yuan (Terry) Tang <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* docs: document permitOnlyProjectScopedClusters field (#15076)

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* docs: kubectl to synchronize argocd apps (#14881)

We can use kubectl to synchronize argocd applications the same way we can use
the argocd cli or ui, however there's no documentation.

This PR adds documentation for kubectl.

Signed-off-by: Jordi Grant Esteve <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* docs: fix typo (#15083)

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* feat: add timeout for update cluster info (#14511)

* chore: simplified parsing of startup parameters

Signed-off-by: yyzxw <[email protected]>

* feat: add timeout for update cluster info

Signed-off-by: yyzxw <[email protected]>

---------

Signed-off-by: yyzxw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix: requeue ApplicationSet if there are validation errors (#14429)

Signed-off-by: Chetan Banavikalmutt <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* docs: fix link for `argocd-repo-creds.yaml` sample (#15091)

Signed-off-by: SHIMADA Kento <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: wrap error objects to include context (#10592) (#15055)

* chore: wrap error objects to include context (#10592)

Signed-off-by: Pawank06 <[email protected]>

* chore: resolved common_test.go file as per reviewer's feedback

Signed-off-by: Pawank06 <[email protected]>

* chore:changes in ulits.go

Signed-off-by: Pawank06 <[email protected]>

* chore: resolving utils_test.go file

Signed-off-by: Pawank06 <[email protected]>

---------

Signed-off-by: Pawank06 <[email protected]>
Signed-off-by: B Pawan Kumar <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix(#12862): Update FlinkDeployment health check to support Flink v1.x (#15065)

Signed-off-by: Dylan Slavin <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* docs: add docs for various annotations and labels (#14020)

* docs: add docs for various annotations

Signed-off-by: Michael Crenshaw <[email protected]>

* more info

Signed-off-by: Michael Crenshaw <[email protected]>

* more docs

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix(appset): bitbucket server scm provider EOF on empty repo (#14411)

* fix bitbucket server scm provider EOF on empty repo default branch check

Signed-off-by: Jedrzej Kotkowski <[email protected]>

* add unit test for bitbucketServer empty repo

Signed-off-by: Jedrzej Kotkowski <[email protected]>

* check for EOF explicitly

Signed-off-by: Jedrzej Kotkowski <[email protected]>

---------

Signed-off-by: Jedrzej Kotkowski <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: update confusing variable name (#15106)

Signed-off-by: jmcshane <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* docs(progressive syncs): specify which ConfigMap to use (#15119)

Signed-off-by: Gaël Jourdan-Weil <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* feat(appset): added topic filter for Gitlab SCM (#14965)

* added topic (tag) filter for Gitlab SCM

Signed-off-by: Prune <[email protected]>

* corrected few comments

Signed-off-by: Prune <[email protected]>

* removed latest tag references

Signed-off-by: Prune <[email protected]>

---------

Signed-off-by: Prune <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: Add kustomization.yaml for server app RBAC (#15124)

This change adds a `kustomization.yaml` file for the example RBAC
role/rolebinding for argocd server applications.
This makes it easier to include them as resources in another `kustomization.yaml`.

Instead of including

```yaml
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- https://raw.githubusercontent.com/argoproj/argo-cd/v2.8.0/examples/k8s-rbac/argocd-server-applications/argocd-server-rbac-clusterrole.yaml
- https://raw.githubusercontent.com/argoproj/argo-cd/v2.8.0/examples/k8s-rbac/argocd-server-applications/argocd-server-rbac-clusterrolebinding.yaml
```

the user can now instead include

```yaml
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- github.com/argoproj/argo-cd/examples/k8s-rbac/argocd-server-applications?ref=v2.8.0
```

This change was performed by running:

```console
kustomize create
kustomize edit add resource argocd-server-rbac-clusterrole.yaml
kustomize edit add resource argocd-server-rbac-clusterrolebinding.yaml
```

Signed-off-by: Andreas Lindhé <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* docs: ✏️ fix typo on configmap name for private certs (#9596)

Signed-off-by: Gaël Jourdan-Weil <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* Merge pull request from GHSA-c8xw-vjgf-94hr

Signed-off-by: pashakostohrys <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix(ui): code lint (#15150)

Signed-off-by: ebuildy <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix: windows build (#15154)

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* feat: run refresh from UI in parallel (#15138)

Signed-off-by: Lukas Wöhrl <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix(cli): add support for components with non-default names (#10200) (#14605)

* fix(cli): add support for components with non-default names (#10200)

Co-Authored-By: maheshbaliga <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: maheshbaliga <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix: Updated docs about using a slash in ignoreDifferences (#15144)

Signed-off-by: Christian Hernandez <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix: stop creating new otel interceptor to avoid memory leak (#15174)

Signed-off-by: Alexander Matyushentsev <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: add example jq path expression (#15130)

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* docs: document sourceNamespaces field (#15195)

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix(appset): Matrix Generator Override not Working for Booleans (#14498) (#14573)

* Fix AppSet matrix generator parameter override

Signed-off-by: Alexander Bellhäuser <[email protected]>

* Add test case for parameter override fix

Signed-off-by: Alexander Bellhäuser <[email protected]>

---------

Signed-off-by: Alexander Bellhäuser <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* docs: remove unnecessary version number (#15198)

We have versioned docs now, no need for this.

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix(ui): switch podgroup notification to tooltip message (#14821)

* improve pod grouping ux

Signed-off-by: ashutosh16 <[email protected]>

fix: update log view on container select

Signed-off-by: ashutosh16 <[email protected]>

* fix(ui): improve pod grouping ux

Signed-off-by: ashutosh16 <[email protected]>

* fix(ui):update the pod grouping messages to tooltip

Signed-off-by: ashutosh16 <[email protected]>

* fix(ui):update the pod grouping messages to tooltip

Signed-off-by: ashutosh16 <[email protected]>

* fix: GroupNodes notification

Signed-off-by: AS <[email protected]>

* fix: GroupNodes notification

Signed-off-by: AS <[email protected]>

---------

Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: AS <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: add upsider to USERS.md (#15228)

Signed-off-by: Vlad Fratila <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* docs: clarify argocd-repo-server repo-cache-expiration HA use case (#15239)

Signed-off-by: phanama <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: better logs for jq expression errors (#15226)

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix(ui): Helm chart empty maintainers blow up Argo UI (#15225)

Signed-off-by: Carlos Castro [email protected]

Signed-off-by: Carlos Castro [email protected]
Signed-off-by: Carlos Castro <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: add Kvist to USERS.md (#15240)

Signed-off-by: Fredrik A. Madsen-Malmo <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* docs: improve doc on labels parameter on scmProvider generator (#15255)

Signed-off-by: Jedrzej Kotkowski <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* docs: Update ApplicationSet docs (#15269)

Signed-off-by: David Muckle <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* feat: support extra attributes for opentelemetry (#15071)

Signed-off-by: penglongli <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* docs: Add Twilio Segment to USERS.md (#15267)

Thank you to the Argo community!

Signed-off-by: Prasad Katti <[email protected]>
Co-authored-by: jannfis <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix: make WatchResourceTree use namespaced cache key (#15258)

* fix: make WatchResourceTree use namespaced application cache key

Signed-off-by: Torbjørn Fjørtoft <[email protected]>

* chore: add PGS to USERS.md

Signed-off-by: Torbjørn Fjørtoft <[email protected]>

---------

Signed-off-by: Torbjørn Fjørtoft <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: remove duplicate function (#15123)

Signed-off-by: yyzxw <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix: Cache control 404 asset requests (#15327)

* backfill cache control header tests for ui assets

Signed-off-by: Scott Windsor <[email protected]>

* Set cache-control header non-cache for assets not found

Signed-off-by: Scott Windsor <[email protected]>

* fix golang-cilint warning

Signed-off-by: Scott Windsor <[email protected]>

---------

Signed-off-by: Scott Windsor <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* docs: Fixes a markdown typo in USERS.md (#15362)

This removes the whitespace between the link text and the link URL.

Signed-off-by: Prasad Katti <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* feat: upgrade notification engine (#15359)

* Update notifications-engine dependencies

Signed-off-by: Mike Splain <[email protected]>

* Update docs

Signed-off-by: Mike Splain <[email protected]>

---------

Signed-off-by: Mike Splain <[email protected]>
Co-authored-by: pasha-codefresh <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* feat: add Dott to users (#15370)

Signed-off-by: Jake Burn <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix(notifications-catalog): Add nil check for on-deployed trigger (#15363)

Signed-off-by: Fs02 <[email protected]>
Co-authored-by: pasha-codefresh <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* feat: auto respect rbac for discovery/sync (#14381)

feat: auto respect rbac for discovery/sync (#14381)

Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* feat: Add ARGOCD_CLUSTER_CACHE_LIST_PAGE_BUFFER_SIZE environment variable (#15159)

Signed-off-by: Brad West <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix(appset): Revert applicationset-name labels (#15324)

* fix(15282) Revert applicationset-name labels

Signed-off-by: gmuselli <[email protected]>

* fix(15282) fix unit test

Signed-off-by: gmuselli <[email protected]>

---------

Signed-off-by: gmuselli <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore(deps): bump library/golang from 1.21.0 to 1.21.1 (#15391)

Bumps library/golang from 1.21.0 to 1.21.1.

---
updated-dependencies:
- dependency-name: library/golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jimmy Neville <[email protected]>

* chore(deps): bump library/golang from 1.21.0 to 1.21.1 in /test/remote (#15387)

Bumps library/golang from 1.21.0 to 1.21.1.

---
updated-dependencies:
- dependency-name: library/golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jimmy Neville <[email protected]>

* chore(deps): bump library/node from 20.4.0 to 20.6.0 in /test/container (#15366)

Bumps library/node from 20.4.0 to 20.6.0.

---
updated-dependencies:
- dependency-name: library/node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jimmy Neville <[email protected]>

* Merge pull request from GHSA-g687-f2gx-6wm8

* feat: use untar with limiter

Signed-off-by: pashakostohrys <[email protected]>

* feat: use untar with limiter

Signed-off-by: pashakostohrys <[email protected]>

---------

Signed-off-by: pashakostohrys <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* Merge pull request from GHSA-fwr2-64vr-xv9m

* fix: prevent seeing/editing 'kubectl.kubernetes.io/last-applied-configuration' cluster annotation

Signed-off-by: Alexander Matyushentsev <[email protected]>

* fix: failing unit test

Signed-off-by: iam-veeramalla <[email protected]>

---------

Signed-off-by: Alexander Matyushentsev <[email protected]>
Signed-off-by: iam-veeramalla <[email protected]>
Co-authored-by: iam-veeramalla <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore(deps): bump library/node from 20.5.0 to 20.6.0 in /ui-test (#15364)

Bumps library/node from 20.5.0 to 20.6.0.

---
updated-dependencies:
- dependency-name: library/node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jimmy Neville <[email protected]>

* fix: handle annotations for resources with ':' in the name (#15101) (#15380)

* fix: handle annotations for resources with ':' in the name

Signed-off-by: Oreon Lothamer <[email protected]>

* fix: switch to using splitN for handling annotation splitting

Signed-off-by: Oreon Lothamer <[email protected]>

* fix: check len(parts) !=3

Signed-off-by: Oreon Lothamer <[email protected]>

* Retrigger CI pipeline

Signed-off-by: Oreon Lothamer <[email protected]>

---------

Signed-off-by: Oreon Lothamer <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* docs: Improve RBAC documentation (#15430)

* Improve staging-db project name

This change renames the project to distinguish it from the role.

Signed-off-by: Andreas Lindhé <[email protected]>

* Rename db-staging role to singular form

Role names should be singular ("User x has the role admin" as opposed to
"User x has the role admins").

Signed-off-by: Andreas Lindhé <[email protected]>

* Remove trailing newlines

Signed-off-by: Andreas Lindhé <[email protected]>

* Consistently mark `AppProject` as code

Signed-off-by: Andreas Lindhé <[email protected]>

* Replace ```shell with ```console in suitable places

Signed-off-by: Andreas Lindhé <[email protected]>

* Use consistent style for unordered list

https://github.com/DavidAnson/markdownlint/blob/main/doc/md004.md

Signed-off-by: Andreas Lindhé <[email protected]>

* Use consistent emphasis style

https://github.com/DavidAnson/markdownlint/blob/main/doc/md049.md

Signed-off-by: Andreas Lindhé <[email protected]>

* Fix incorrect description of the staging-db example

Signed-off-by: Andreas Lindhé <[email protected]>

---------

Signed-off-by: Andreas Lindhé <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix(appsets): gotemplate can cause panic from nil dereference (#15377) (#15378)

* fix(appsets): gotemplate can cause panic from nil deference

Signed-off-by: rumstead <[email protected]>

* fix(appsets): gotemplate can cause panic from nil dereference

Signed-off-by: rumstead <[email protected]>

---------

Signed-off-by: rumstead <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: Fix flaky cluster test (#15433)

Signed-off-by: Jimmy Neville <[email protected]>

* Fix requeue after for Matrix/Merge with SCM or ClusterDecision generators (#15407)

Signed-off-by: Cezar Sa Espinola <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* feat: added shorthand flags for follow and conatainre in app logs (#15400)

* feat: added shorthand flags for follow and conatainre in app logs

Signed-off-by: ashu <[email protected]>

* doc: re-generated cli docs

Signed-off-by: ashu <[email protected]>

---------

Signed-off-by: ashu <[email protected]>
Co-authored-by: jannfis <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* [Bot] docs: Update Snyk reports (#15437)

Signed-off-by: CI <[email protected]>
Co-authored-by: CI <[email protected]>
Co-authored-by: jannfis <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix: Better enforcement of application namespace restrictions (#15431)

* fix: Better enforce application namespace restrictions

Signed-off-by: jannfis <[email protected]>

* Only call ValidateDestination when allowed

Signed-off-by: jannfis <[email protected]>

---------

Signed-off-by: jannfis <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* docs: fix bullets (#15446)

Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix: failed to add cluster when the cluster server address is ipv6 (#8204) (#15350)

* fix: failed to add cluster when the cluster server address is ipv6 (#8204)

Signed-off-by: huyinhou <[email protected]>

* fix: failed to add cluster when the cluster server address is ipv6 (#8204)

Signed-off-by: huyinhou <[email protected]>

* remove unused import

Signed-off-by: huyinhou <[email protected]>

* fix: lowercase URI secret name; abbreviated IPv6 address

Signed-off-by: huyinhou <[email protected]>

---------

Signed-off-by: huyinhou <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* feat: Enable haproxy metrics through helm Chart (#15459)

Signed-off-by: Mathias Petermann <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* Stop appending :443 to the server address when using grpc-web (#15435)

Signed-off-by: David Marby <[email protected]>
Co-authored-by: jannfis <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* feat: appset preserve labels and global preserve fields (#15445)

* feat: appset preserve labels and global preserve fields

Signed-off-by: Soumya Ghosh Dastidar <[email protected]>

* feat: appset preserve labels and global preserve fields

Signed-off-by: Soumya Ghosh Dastidar <[email protected]>

* docs: updated docs

Signed-off-by: Soumya Ghosh Dastidar <[email protected]>

* docs: updated docs

Signed-off-by: Soumya Ghosh Dastidar <[email protected]>

---------

Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* fix: Gitlab scm_provider - don't create transport from scratch (#15424) (#15425)

* fix : don't create transport from scratch, clone it instead

Signed-off-by: Antoine Jouve <[email protected]>

* feat: clone http.transport for gitea and gitlab providers

Signed-off-by: Antoine Jouve <[email protected]>

* chore: properly format gitea providers with gofmt

Signed-off-by: Antoine Jouve <[email protected]>

---------

Signed-off-by: Antoine Jouve <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* chore: add Factorial to USERS.md (#15473)

Signed-off-by: Alejandro López Sánchez <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>

* Fix incorrect wording in Appli…
  • Loading branch information
@Jneville0815 @schakrad
@dependabot @Niksko @crenshaw-dev @ashutosh16 @daftping @terrytangyuan @ciiay @gerardocorea @mmerrill3 @agaudreault @Fish-pro @xianzheTM @speedfl @blakepettersson @alexmt @soupdiver @github-actions @GenPage @jgwest @kostis-codefresh @alexec @ichbinfrog @jessebot @leoluz @morey-tech @ashinsabu3 @taliastocks @xashr @Zebradil @vipinachar @prune998 @todaywasawesome @mcanevet @sabre1041 @zvlb @yuezk @jmeridth @robinlieb @bt-macole @aslafy-z @Reamer @pasha-codefresh @agilgur5 @LinAnt @AvhiMaz @selaci @yyzxw @chetan-rns @hitsumabushi845 @Pawank06 @dylanslavin @jjsiv @jmcshane @gaeljw @lindhe @ebuildy @woehrl01 @maheshbaliga @christianh814 @alexbde @vladfr @phanama @carloscastrojumo @FredrikAugust @dvdmuckle @penglongli @prasadkatti @jannfis @torfjor @sentientmonkey @mikesplain @burnjake @Fs02 @gdsoumya @bradgwest @iam-veeramalla @oreonl @rumstead @cezarsa @ashupednekar @jsoref @huyinhou @peschmae @DMarby @an-toine @alopezsanchez @risset @tchellomello @Ansuman28 @maxbrunet @zhaque44 @harm-matthias-harms @kurtaking @kmadel @LStuker @ozlevka-work @digiserg @sridharnandigam @mooneeb @Timoses @ishitasequeira @34fathombelow @mikeshng @ymktmk @ericblackburn @PranitRout07 @SergeyLadutko @anandf @rbreeze @jmilic1
116 people authored and jmilic1 committed Nov 13, 2023
1 parent 44596c6 commit b02ea5c
Show file tree
Hide file tree
Showing 2 changed files with 70 additions and 28 deletions.
2 changes: 1 addition & 1 deletion docs/operator-manual/custom-styles.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ experience, you may wish to build a separate project using the [Argo CD UI dev s

## Banners

Argo CD can optionally display a banner that can be used to notify your users of upcoming maintenance and operational changes. This feature can be enabled by specifying the banner message using the `ui.bannercontent` field in the `argocd-cm` ConfigMap and Argo CD will display this message at the top of every UI page. You can optionally add a link to this message by setting `ui.bannerurl`. You can also make the banner sticky (permanent) by setting `ui.bannerpermanent` to `true` and change it's position to the bottom by using `ui.bannerposition: "bottom"`
Argo CD can optionally display a banner that can be used to notify your users of upcoming maintenance and operational changes. This feature can be enabled by specifying the banner message using the `ui.bannercontent` field in the `argocd-cm` ConfigMap and Argo CD will display this message at the top of every UI page. You can optionally add a link to this message by setting `ui.bannerurl`. You can also make the banner sticky (permanent) by setting `ui.bannerpermanent` to true and change its position to "both" or "bottom" by using `ui.bannerposition: "both"`, allowing the banner to display on both the top and bottom, or `ui.bannerposition: "bottom"` to display it exclusively at the bottom.

### argocd-cm
```yaml
Expand Down
96 changes: 69 additions & 27 deletions ui/src/app/ui-banner/ui-banner.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,46 @@ import {DataLoader} from '../shared/components';
import {services, ViewPreferences} from '../shared/services';
import './ui-banner.scss';

const CustomBanner = (props: {
combinedBannerClassName: string;
show: boolean;
heightOfBanner: string;
leftOffset: string;
permanent: boolean;
url: string;
content: string;
setVisible: (visible: boolean) => void;
prefs: object;
}) => {
return (
<div className={props.combinedBannerClassName} style={{visibility: props.show ? 'visible' : 'hidden', height: props.heightOfBanner, marginLeft: props.leftOffset}}>
<div className='ui-banner-text' style={{maxHeight: props.permanent ? '25px' : '50px'}}>
{props.url !== undefined ? (
<a href={props.url} target='_blank' rel='noopener noreferrer'>
{props.content}
</a>
) : (
<React.Fragment>{props.content}</React.Fragment>
)}
</div>
{!props.permanent ? (
<>
<button className='ui-banner-button argo-button argo-button--base' style={{marginRight: '5px'}} onClick={() => props.setVisible(false)}>
Dismiss for now
</button>
<button
className='ui-banner-button argo-button argo-button--base'
onClick={() => services.viewPreferences.updatePreferences({...props.prefs, hideBannerContent: props.content})}>
Don't show again
</button>
</>
) : (
<></>
)}
</div>
);
};

export const Banner = (props: React.Props<any>) => {
const [visible, setVisible] = React.useState(true);
return (
Expand Down Expand Up @@ -60,9 +100,8 @@ export const Banner = (props: React.Props<any>) => {
const isTop = position !== 'bottom';
const bannerClassName = isTop ? 'ui-banner-top' : 'ui-banner-bottom';
const wrapperClassname = bannerClassName + '--wrapper ' + (!permanent ? bannerClassName + '--wrapper-multiline' : bannerClassName + '--wrapper-singleline');
const combinedBannerClassName = isTop ? 'ui-banner ui-banner-top' : 'ui-banner ui-banner-bottom';
let chatBottomPosition = 10;
if (show && !isTop) {
if (show && (!isTop || position === 'both')) {
if (permanent) {
chatBottomPosition = 40;
} else {
Expand All @@ -77,33 +116,36 @@ export const Banner = (props: React.Props<any>) => {
chatUrl = 'invalid-url';
}
}
const shouldRenderTop = position === 'top' || position === 'both';
const shouldRenderBottom = position === 'bottom' || position === 'both';
return (
<React.Fragment>
<div className={combinedBannerClassName} style={{visibility: show ? 'visible' : 'hidden', height: heightOfBanner, marginLeft: leftOffset}}>
<div className='ui-banner-text' style={{maxHeight: permanent ? '25px' : '50px'}}>
{url !== undefined ? (
<a href={url} target='_blank' rel='noopener noreferrer'>
{content}
</a>
) : (
<React.Fragment>{content}</React.Fragment>
)}
</div>
{!permanent ? (
<>
<button className='ui-banner-button argo-button argo-button--base' style={{marginRight: '5px'}} onClick={() => setVisible(false)}>
Dismiss for now
</button>
<button
className='ui-banner-button argo-button argo-button--base'
onClick={() => services.viewPreferences.updatePreferences({...prefs, hideBannerContent: content})}>
Don't show again
</button>
</>
) : (
<></>
)}
</div>
{shouldRenderTop && (
<CustomBanner
combinedBannerClassName={'ui-banner ui-banner-top'}
show={show}
heightOfBanner={heightOfBanner}
leftOffset={leftOffset}
permanent={permanent}
url={url}
content={content}
setVisible={setVisible}
prefs={prefs}
/>
)}
{shouldRenderBottom && (
<CustomBanner
combinedBannerClassName={'ui-banner ui-banner-bottom'}
show={show}
heightOfBanner={heightOfBanner}
leftOffset={leftOffset}
permanent={permanent}
url={url}
content={content}
setVisible={setVisible}
prefs={prefs}
/>
)}
{show ? <div className={wrapperClassname}>{props.children}</div> : props.children}
{chatUrl && (
<div style={{position: 'fixed', right: 10, bottom: chatBottomPosition}}>
Expand Down

0 comments on commit b02ea5c

Please sign in to comment.