Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect expected value of fractional(0.333) in the readme #133

Closed
eldipa opened this issue Jun 14, 2020 · 1 comment · Fixed by #134
Closed

Incorrect expected value of fractional(0.333) in the readme #133

eldipa opened this issue Jun 14, 2020 · 1 comment · Fixed by #134
Labels
bug Something isn't working

Comments

@eldipa
Copy link
Contributor

eldipa commented Jun 14, 2020

What did you do?

I ran byexample to verify the examples in the readme:

byexample -l python README.md

I also confirmed the issue running the example in a python console.

What did you expect to happen?

The readme says:

>>> humanize.fractional(0.333)
'1/3'

What actually happened?

Instead of '1/3' it returns '333/1000'

The value returned is probably the correct one, I think that the readme should be updated.

What versions are you using?

  • OS: Debian 9
  • Python: Python 3.5
  • Humanize: master
@hugovk hugovk added the bug Something isn't working label Jun 15, 2020
@hugovk
Copy link
Collaborator

hugovk commented Jun 15, 2020

Thanks! I've made PR #134 to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants