Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fractional(0.333) output in README #134

Merged
merged 2 commits into from
Jun 20, 2020
Merged

Fix fractional(0.333) output in README #134

merged 2 commits into from
Jun 20, 2020

Conversation

hugovk
Copy link
Collaborator

@hugovk hugovk commented Jun 15, 2020

Fixes #133.

Changes proposed in this pull request:

  • Add the fractional examples from the README as test cases
  • Fix the output of humanize.fractional(0.333) from '1/3' to '333/1000' in the README and test case
  • Add some missing quotes around string outputs

@hugovk hugovk added bug Something isn't working changelog: Fixed For any bug fixes labels Jun 15, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2020

Codecov Report

Merging #134 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #134   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          416       416           
=========================================
  Hits           416       416           
Flag Coverage Δ
#GHA_Ubuntu 100.00% <ø> (ø)
#GHA_Windows 100.00% <ø> (ø)
#GHA_macOS 100.00% <ø> (ø)
Impacted Files Coverage Δ
tests/test_number.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8af6a1...b6040db. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working changelog: Fixed For any bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect expected value of fractional(0.333) in the readme
2 participants