Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Represent with a zero if the delta is too small #170

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Represent with a zero if the delta is too small #170

merged 1 commit into from
Oct 19, 2020

Conversation

eldipa
Copy link
Contributor

@eldipa eldipa commented Oct 19, 2020

Fixes #159

Changes proposed in this pull request:

If the delta is too small to be represented with the minimum unit,
represent it as "0 X" where X is the minimum unit.

If the delta is too small to be represented with the minimum unit,
represent it as "0 X" where X is the minimum unit.

Fixes #159
@codecov-io
Copy link

codecov-io commented Oct 19, 2020

Codecov Report

Merging #170 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #170   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          569       569           
=========================================
  Hits           569       569           
Flag Coverage Δ
#GHA_Ubuntu 100.00% <100.00%> (ø)
#GHA_Windows 100.00% <100.00%> (ø)
#GHA_macOS 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_time.py 100.00% <ø> (ø)
src/humanize/time.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d9de69...62706fd. Read the comment docs.

@hugovk
Copy link
Collaborator

hugovk commented Oct 19, 2020

Looks good, thank you!


PyPy3 / Windows failure looks unrelated, also occurs on master and already reported at actions/setup-python#151.

@hugovk hugovk added the bug Something isn't working label Oct 19, 2020
@hugovk hugovk merged commit 809e66b into jmoiron:master Oct 19, 2020
@hugovk hugovk added the changelog: Fixed For any bug fixes label Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working changelog: Fixed For any bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

precisedelta with minimum unit seconds fails when seconds is a very small value
3 participants