Remove deprecated private function aliases #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, these functions and enum were deprecated. This change removes the public alias to these functions.
Prior to this change, these functions were deprecated. This change removes the public alias to these functions.
Codecov Report
@@ Coverage Diff @@
## master #241 +/- ##
==========================================
+ Coverage 97.65% 99.69% +2.04%
==========================================
Files 10 10
Lines 681 659 -22
==========================================
- Hits 665 657 -8
+ Misses 16 2 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hugovk
approved these changes
Nov 29, 2021
…-private-function-aliases
hugovk
force-pushed
the
remove-deprecated-private-function-aliases
branch
from
fdd4716
to
79a4d48
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes aliases for deprecated functions introduced in #234.
This completes the deprecation of these public functions (the functions are still accessible as private members of their modules).