Use humanize.intcomma
to format years in time
module
#246
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #245
Presently, it is hard to read very long times because the largest time denomination that
humanize
includes is years. In this pull request,humanize.intcomma()
is now used to format the number of years returned bynaturaldelta()
andprecisedelta()
.Alternate approaches considered include:
millennia
denomination, but this would require all translations to be updated.{:n}
format specifier along with the standardlocale
module, but locale has inconsistent behavior across platforms andhumanize
already uses an internal localization module.