Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't deprecate time.Unit enumeration #252

Merged
merged 1 commit into from
Jan 30, 2022
Merged

Don't deprecate time.Unit enumeration #252

merged 1 commit into from
Jan 30, 2022

Conversation

hugovk
Copy link
Collaborator

@hugovk hugovk commented Jan 30, 2022

Replaces and closes #244.

Changes proposed in this pull request:

@hugovk hugovk added the changelog: Changed For changes in existing functionality label Jan 30, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2022

Codecov Report

Merging #252 (1bedec1) into master (35201aa) will increase coverage by 0.54%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
+ Coverage   97.10%   97.65%   +0.54%     
==========================================
  Files          10       10              
  Lines         692      681      -11     
==========================================
- Hits          672      665       -7     
+ Misses         20       16       -4     
Flag Coverage Δ
GHA_Ubuntu 96.47% <100.00%> (+0.52%) ⬆️
GHA_Windows 96.18% <100.00%> (+0.51%) ⬆️
GHA_macOS 96.47% <100.00%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/humanize/time.py 98.15% <100.00%> (+1.66%) ⬆️
tests/test_time.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35201aa...1bedec1. Read the comment docs.

@hugovk hugovk merged commit 309e7fd into jmoiron:master Jan 30, 2022
@hugovk hugovk deleted the dont-deprecate-Unit branch January 30, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Changed For changes in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants