Issue #233: Move endpoints related to amenities from community tag

[JanneSickert]

Closes: #233

[codecov]

Codecov Report

Merging #253 (39faff4) into master (f7ec6a4) will not change coverage.
The diff coverage is 50.00%.

@@            Coverage Diff            @@
##             master     #253   +/-   ##
=========================================
  Coverage     68.28%   68.28%           
  Complexity      200      200           
=========================================
  Files            34       34           
  Lines           864      864           
  Branches         41       41           
=========================================
  Hits            590      590           
  Misses          266      266           
  Partials          8        8           

Impacted Files	Coverage Δ	Complexity Δ
...va/com/myhome/controllers/CommunityController.java	98.90% <ø> (+3.95%)	31.00 <0.00> (-2.00)	⬆️
...java/com/myhome/controllers/AmenityController.java	85.18% <50.00%> (-14.82%)	10.00 <2.00> (+2.00)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7ec6a4...24e1060. Read the comment docs.

[mslowiak]

@JanneSickert
Please read the comments.
There is also one more issue related to code formatting.

Did you applied our code style to your editor? Looks like you use default editor config, please take a look here:
https://github.com/jmprathab/MyHome/blob/master/CONTRIBUTING.md#coding-style

and here:
https://www.jetbrains.com/help/idea/configuring-code-style.html

[mslowiak]

Since CommunityController do not have a connection to amenity more we should not include the amenity testing logic here :)
That should a part of AmenityControllerTest

[mslowiak]

Wildcards imports.
Why is it bad? Read it here https://stackoverflow.com/questions/147454/why-is-using-a-wild-card-with-a-java-import-statement-bad

How you can fix it in intellij?
https://stackoverflow.com/a/25916603/5785871

[mslowiak]

@JanneSickert
How is it going?

[JanneSickert]

I had also copyed two methods depending from the

@Injectmocks
private AmenityController amenityController;

I executed

• gradle assemble
• gradle clean build

and it had build without any errors.
If it was right to move the methods, I only must running Code Style and can rise a PR.

[JanneSickert]

Oh, I mean rise a commit :)