Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue Fixed #232: Move endpoints related to houses from community tag… #280

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Dark-Ultron
Copy link

🚀 Description

Endpoints GET /communities/{communityId}/houses, POST /communities/{communityId}/houses, DELETE /communities/{communityId}/houses/{houseId} moved to Houses tag and moved associated methods from CommunityController.java to HouseController.java.

📄 Motivation and Context

Issue #232 fix

🧪 How Has This Been Tested?

  • checked if mentioned endpoints related to houses moved to houses tag in swagger.
  • tested manually by hitting the corresponding endpoints using postman.

📷 Screenshots (if appropriate)

image

📦 Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

  • My code follows the code style of this project(Do your best to follow code styles. If none apply just skip this).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

…unity tag and moved associated methods from CommunityController to HouseController
…points depedend upon community services and CommunityMapper so decided to keep it in CommunityControllerTest and mock HouseController in it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant