No more plugins #37
Merged
No more plugins #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javuto
added
refactor
pmoody-
reviewed
Feb 20, 2020
Merged
|
@javuto https://osctrl.net/configuration/#logging links to a plugins directory that this PR appears to have removed. |
CptOfEvilMinions
added a commit
that referenced
this pull request
Dec 28, 2021
Update build pipeline - 6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Logging data in
osctrl-tlswas using go plugins because whynot, but it turns out that using unstable stuff is tricky so let's keep it in a separate branch and move on.Now
loggingis its own package and it will contain all supported logging mechanisms.Also some refactoring to have
backendas the package that connects to the database.Thanks in advance for the code review @obelisk @pmoody-