Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing query results and osctrl-admin panics #449

Merged
merged 2 commits into from
Jul 6, 2024
Merged

Missing query results and osctrl-admin panics #449

merged 2 commits into from
Jul 6, 2024

Conversation

javuto
Copy link
Collaborator

@javuto javuto commented Jul 6, 2024

When trying to retrieve on-demand query results, or any other results that may be stored in the DB, the osctrl-admin service was invoking a nil pointer, causing a panic. This PR fixes several issues, including #438:

  • Display a message when the logger is not configured to db, and there are no logs to display.
  • Making sure keys in redis are expired.
  • The JSON setting for logger was not stored in the DB correctly.

@javuto javuto added osctrl-admin osctrl-admin related changes 🗄️ logging Logging related issues 🚧 bugfix Fix for an existing bug cache Cache related issues labels Jul 6, 2024
@javuto javuto self-assigned this Jul 6, 2024
@javuto javuto merged commit e0746dc into main Jul 6, 2024
52 checks passed
@javuto javuto deleted the missing-query-results branch July 6, 2024 17:44
@BrewTestBot BrewTestBot mentioned this pull request Jul 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@javuto javuto

Labels
🚧 bugfix Fix for an existing bug cache Cache related issues 🗄️ logging Logging related issues osctrl-admin osctrl-admin related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@javuto