Skip to content

Commit

Permalink
symbolize keys that are passed to provider methods
Browse files Browse the repository at this point in the history
  • Loading branch information
Jillian Tullo committed Apr 6, 2017
1 parent fbb84f2 commit 22e0867
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion app/controllers/api/authentications_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ class AuthenticationsController < BaseController
def edit_resource(type, id, data)
auth = resource_search(id, type, collection_class(:authentications))
raise "Update not supported for #{authentication_ident(auth)}" unless auth.respond_to?(:update_in_provider_queue)
task_id = auth.update_in_provider_queue(data)
task_id = auth.update_in_provider_queue(data.deep_symbolize_keys)
action_result(true, "Updating #{authentication_ident(auth)}", :task_id => task_id)
rescue => err
action_result(false, err.to_s)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ class ConfigurationScriptSourcesController < BaseController
def edit_resource(type, id, data)
config_script_src = resource_search(id, type, collection_class(:configuration_script_sources))
raise "Update not supported for #{config_script_src_ident(config_script_src)}" unless config_script_src.respond_to?(:update_in_provider_queue)
task_id = config_script_src.update_in_provider_queue(data)
task_id = config_script_src.update_in_provider_queue(data.deep_symbolize_keys)
action_result(true, "Updating #{config_script_src_ident(config_script_src)}", :task_id => task_id)
rescue => err
action_result(false, err.to_s)
Expand All @@ -25,7 +25,7 @@ def create_resource(_type, _id, data)
manager = resource_search(manager_id, :providers, collection_class(:providers))
type = ConfigurationScriptSource.class_for_manager(manager)
raise "ConfigurationScriptSource cannot be added to #{manager_ident(manager)}" unless type.respond_to?(:create_in_provider_queue)
task_id = type.create_in_provider_queue(manager.id, data.except('manager_resource'))
task_id = type.create_in_provider_queue(manager.id, data.except('manager_resource').deep_symbolize_keys)
action_result(true, "Creating ConfigurationScriptSource for #{manager_ident(manager)}", :task_id => task_id)
rescue => err
action_result(false, err.to_s)
Expand Down
2 changes: 1 addition & 1 deletion lib/services/api/authentication_service.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ def self.create_authentication_task(manager_resource, attrs)
klass = ::Authentication.class_from_request_data(attrs)
# TODO: Temporary validation - remove
raise 'type not currently supported' unless klass.respond_to?(:create_in_provider_queue)
klass.create_in_provider_queue(manager_resource.id, attrs)
klass.create_in_provider_queue(manager_resource.id, attrs.deep_symbolize_keys)
end
end
end

0 comments on commit 22e0867

Please sign in to comment.