Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom http connection factories #157

Merged
merged 2 commits into from
Sep 7, 2012
Merged

Add support for custom http connection factories #157

merged 2 commits into from
Sep 7, 2012

Conversation

soupmatt
Copy link
Contributor

I followed the same pattern used for the parser. This opens the door to being able to do things like use a pool of persistent HTTP connections. Let me know what you think and if there are any changes you would like to see.

@travisbot
Copy link

This pull request fails (merged 22bd579 into 9c08f47).

@soupmatt
Copy link
Contributor Author

no fair travis! the build failed because of a vagrant error, not a code problem. :(

@soupmatt
Copy link
Contributor Author

@jnunemaker, let me know when you think and if you want me to send you another pull request with the commits squashed.

Also, I'm planning on writing a connection adapter that does persistent http connections using the persistent_http gem. Would you be interested in having that be a part of httparty? Let me know as I'll release it as a separate gem otherwise.

@jnunemaker
Copy link
Owner

Definitely separate. I'd like to keep dependencies to a minimum.

On Aug 13, 2012, at 7:44 PM, Matt Campbell [email protected] wrote:

@jnunemaker, let me know when you think and if you want me to send you another pull request with the commits squashed.

Also, I'm planning on writing a connection adapter that does persistent http connections using the persistent_http gem. Would you be interested in having that be a part of httparty? Let me know as I'll release it as a separate gem otherwise.


Reply to this email directly or view it on GitHub.

@soupmatt
Copy link
Contributor Author

@jnunemaker, is there any other changes you would want to this pull request? I am hoping to release a gem that uses this feature to enable persistent http connections in the next week or two.

@jnunemaker
Copy link
Owner

Looking it over now.

@jnunemaker jnunemaker merged commit 22bd579 into jnunemaker:master Sep 7, 2012
@soupmatt
Copy link
Contributor Author

soupmatt commented Sep 9, 2012

thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants