Implemented support for MKCOL method #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKCOL - part of the HTTP Extensions for Distributed Authoring (also known as WebDAV) - allow creation of a new collection resource at the location specified. By extending with MKCOL method, will cover basic WebDAV implementation and make httparty more generic and increase the fun.
| @@ -9,7 +9,8 @@ class Request #:nodoc: | |||
| Net::HTTP::Head, | |||
| Net::HTTP::Options, | |||
| Net::HTTP::Move, | |||
| Net::HTTP::Copy | |||
| Net::HTTP::Copy, | |||
| Net::HTTP::Mkcol | |||
There was a problem hiding this comment.
Would you add a trailing comma here so we don't end up with a diff like this next time something is added?
There was a problem hiding this comment.
Had actually thought about it, but decided to avoid in the first place to keep konsistency with the original.
It has been added now in 5f94172 😃
|
Seems fine. I know nothing about it, so I guess we'll see how it goes with maintenance on it going forward. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MKCOL- part of the HTTP Extensions for Distributed Authoring (also known as WebDAV) - allow creation of a new collection resource at the location specified.By extending with the
MKCOLmethod, will cover (most) basic WebDAV implementation and makehttpartymore generic and increase the fun 😄