Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multipart uploads with boolean params. #575

Merged
merged 1 commit into from
Feb 27, 2018

Conversation

rywall
Copy link
Contributor

@rywall rywall commented Feb 24, 2018

I am using a gem (ocr_space) that passes a boolean param to HTTParty.post. This started failing in v0.16 with the following error message:

TypeError: no implicit conversion of false into String
from /gems/httparty-0.16.0/lib/httparty/request/body.rb:40:in `+'

@jnunemaker
Copy link
Owner

I'm going to merge this. I have some hesitation adding the to_s as it could cover up passing in nil or other not serializable objects accidentally, but we'll see how it goes. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants