Expose .connection on fragment block param #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machty
force-pushed
the
expose-connection
branch
2 times, most recently
from
71f5801
to
40204f2
Compare
machty
changed the title
machty
force-pushed
the
expose-connection
branch
from
40204f2
to
d5a24db
Compare
|
@TheSmartnik Ready for your review. Wondering if |
This provides access to the connection object, which in turn exposes properties like `.peer_cert` for performing additional validation against x509 certificates. Closes jnunemaker#633, Follow-up to jnunemaker#634
machty
force-pushed
the
expose-connection
branch
from
d5a24db
to
75594cd
Compare
|
@TheSmartnik Hi, just checking in for an update. |
|
@TheSmartnik Pinging for feedback :) |
|
@machty thanks! Great job! I'll rename the class myself before releasing a new version, so no worries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides access to the connection object,
which in turn exposes properties like
.peer_certfor performing additional validation against
x509 certificates.
Closes #633, Follow-up to #634