make work on zig 0.13.0 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`zig build` on a project with `linenoize` as a dependency was
failing with:
no field named 'path' in union 'Build.LazyPath'
joachimschmidt557
merged commit c50994f
into
joachimschmidt557:master
1 of 3 checks passed
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines two changes:
build.zigto useb.path, since the LazyPath struct has changedstd.ostostd.posixfor termios (taken from Update termios location in std #23 (but also see compatibility: termios removed in zig 0.12 #25))Getting the library to work under 0.13.0 will also require updating
build.zig.zonwith the fixed version of thewcwidthdependency, once (if) joachimschmidt557/zig-wcwidth#5 gets merged.With these changes, and pointing my local clone to a fixed version of the
wcwidthdependency,zig build testbuilds and runs cleanly.Thank you for the library, and let me know if I can help get this across the line!