Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #52: Use entire line as xref summary when possible #103

Closed
wants to merge 1 commit into from
Closed

Close #52: Use entire line as xref summary when possible #103

wants to merge 1 commit into from

Conversation

mkcms
Copy link
Collaborator

@mkcms mkcms commented Sep 8, 2018

This commit makes xref items show entire line where a reference was found.
For performance reasons, I made it only show that line when a buffer visiting the reference was found, although I didn't really benchmark.

* eglot.el (eglot--xref-make): Make the item with summary being the
  whole line at given location.
(xref-backend-identifier-at-point):
(xref-backend-definitions):
(xref-backend-references): Pass Location plist to eglot--xref-make.
@cmm
Copy link
Contributor

cmm commented Oct 4, 2018

  1. The CI failure seems transient and unrelated to the PR's content

  2. lsp-mode shows xref entry context for both already-opened and unopened files (they use with-temp-file or something for the latter) -- if there are any performance complaints because of this, I don't know of any. Given the amount of RAM on today's normal developer machine and how modern FS caches work, I don't see why that would adversely impact the interactive experience in any way

@mkcms
Copy link
Collaborator Author

mkcms commented Oct 6, 2018

I'm closing this PR in favor of #127.

@mkcms mkcms closed this Oct 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants