CLN deprecate bytes_limit from Memory #1447
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter
bytes_limit
fromMemory
is misleading as it makes the user believe that this will be enforced automatically, whereas the user needs to callMemory.reduce_size
to enforce this.As this parameter can be directly passed to
Memory.reduce_size
, along withitems_limit
andage_limit
since #1200, I propose to deprecate it from theMemory
class.