Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type "Number" is generating Floats instead of Double #141

Closed
LeeGDavis opened this issue Jan 29, 2014 · 4 comments
Closed

Type "Number" is generating Floats instead of Double #141

LeeGDavis opened this issue Jan 29, 2014 · 4 comments
Milestone

Comments

@LeeGDavis
Copy link

I just upgraded to 0.4.0 gradle plugin from 0.3.7 ant plugin and seeing numbers being converted to Floats instead of the previous Double. Is this expected?

@LeeGDavis
Copy link
Author

I see #135 addresses this change. Works great!

@joelittlejohn
Copy link
Owner

Thanks for reporting this Lee, this isn't the expected behaviour. The Gradle plugin has the wrong default applied, the default should be useDoubleNumbers=true to avoid exactly this compatibility problem.

I'm going to change this default for the next release. Unfortunately this will be another breaking change (some people will find that their floats become doubles) but I think it's worth it to bring the Gradle plugin back in line with everything else.

@joelittlejohn joelittlejohn reopened this Jan 30, 2014
@LeeGDavis
Copy link
Author

No worries, on that note, can this also be added to the example for the gradle plugin. I didn't see it specifically noted in the readme.

@joelittlejohn
Copy link
Owner

done.

On 30 January 2014 16:23, Lee Davis [email protected] wrote:

No worries, on that note, can this also be added to the example for the
gradle plugin. I didn't see it specifically noted in the readme.


Reply to this email directly or view it on GitHubhttps://github.com//issues/141#issuecomment-33703941
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants