Support direct class inheritance with 'extendsJavaType', without using 'extends'

[ahanin]

I found javaInterfaces rule useful, but, unfortunately, it doesn't meet all my needs. When generating POJOs I sometimes want them to inherit already existing class, that is not generated from schema, therefore extends is not enough.

The solution to this could be a new extendsJavaClass rule to compliment javaInterfaces, which would take a java type to extends. Generics should be supported too. This way, another feature, is maybe required - reference a class being generated. extends and extendsJavaClass must be mutually exclusive.

Example (article.schema):

{ "type": "object",
  "extendsJavaClass": "tld.example.Pageable<${this}>" }

${this} (or any other placeholder) would have to be replace by the actual class name being generated, e.g.:

public class ArticlePageable extends Pageable<Article> {
  // ...
}

[ahanin]

The proposed change is reflected in a pull request: #403

[brentryan]

You can use extends with a javaType field and it works fine with existing classes. Did you try this?

[ahanin]

I tried with the latest snapshot and it didn't work for the type. Can you
give an example?
On Aug 25, 2015 11:36 PM, "brentryan" [email protected] wrote:

You can use extends with a javaType field and it works fine with existing
classes. Did you try this?

—
Reply to this email directly or view it on GitHub
#402 (comment)
.

[joelittlejohn]

@ahanin an example of what @brentryan is talking about would be:

{
  "type" : "object",
  "extends" : {
    "type" : "object",
    "javaType" : "com.example.MyExistingType"
  }
}

It's a bit of a workaround and is a bit more intrusive in the schema than you were hoping. I was happy to merge as people have asked about this kind of feature in the past, and it's possible to implement this as a nicely isolated extension property.

[ahanin]

Ah, nice. Good to know. I am perhaps documentation blind :)
On Aug 26, 2015 5:07 PM, "Joe Littlejohn" [email protected] wrote:

@ahanin https://github.com/ahanin an example of what @brentryan
https://github.com/brentryan is talking about would be:

{
"type" : "object",
"extends" : {
"type" : "object",
"javaType" : "com.example.MyExistingType"
}
}

It's a bit of a workaround and is a bit more intrusive in the schema than
you were hoping. I was happy to merge as people have asked about this kind
of feature in the past, and it's possible to implement this as a nicely
isolated extension property.

—
Reply to this email directly or view it on GitHub
#402 (comment)
.

[anhquande]

It works only when using maven jsonschema2pojo:generate.
But when i use "maven clean install", the existing class is changed (generated) by the plugin. That is what it is not supposed to do.

Updated: adding phase in the pom.xml will solve the problem

                <executions>
                    <execution>
                        <id>generate</id>
                        <goals>
                            <goal>generate</goal>
                        </goals>
                        <phase>
                            compile
                        </phase>
                    </execution>
                </executions>```

[ahanin]

@anhquande would you create a relevant issue?

[evonsdesigns]

If you reference a class from one of the dependencies, like where the custom annotator would live, you don't need to add phase.