Allow JSON to be passed as a String to SchemaMapper #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| switch (ruleFactory.getGenerationConfig().getSourceType()) { | ||
| case JSON: | ||
| JsonNode jsonNode = mapper.readTree(json); | ||
| schemaNode = schemaGenerator.schemaFromExample(jsonNode); |
|
Thanks a lot for submitting this, I've made some minor review comments. If you fix these up, I will merge and release this in 0.4.19. |
|
@joelittlejohn I have fixed the code as per your comments. Please review. Thanks! |
|
Thanks @Raks81. One final step, please squash these commits into one. |
rr-on-gh
force-pushed
the
json-to-schema
branch
from
641342b
to
27f2b1e
Compare
|
@joelittlejohn I have squashed the commmits. Please review. Thanks! |
joelittlejohn
added a commit
that referenced
this pull request
Jan 6, 2016
Allow JSON to be passed as a String to SchemaMapper
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for #255 to allow example JSON to be passed to SchemaMapper as String. Currently it needs to be passed as an URL which is not always convenient. Fix #221 only added support for JSON schema. This PR adds support for example JSON as well.