Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

includeDynamicAccessors should default to false (don't include dynamic accessors by default) #482

Conversation

ctrimble
Copy link
Collaborator

@ctrimble ctrimble commented Jan 8, 2016

Changes the default value of includeDynamicAccessors to false.

@joelittlejohn
Copy link
Owner

Thanks for the quick update! 👍

joelittlejohn added a commit that referenced this pull request Jan 8, 2016
…lt-off

includeDynamicAccessors default false
@joelittlejohn joelittlejohn merged commit ff0ad46 into joelittlejohn:master Jan 8, 2016
@joelittlejohn
Copy link
Owner

I think we should also update this argument to --include-dynamic-accessors:

private boolean disableDynamicAccessors = false;

This will be a minor breaking change, but I'd rather have this argument change than have inconsistency between the tools.

@ctrimble
Copy link
Collaborator Author

ctrimble commented Jan 8, 2016

Thought I might have missed one. Let me see about getting that fixed.

@joelittlejohn joelittlejohn changed the title includeDynamicAccessors default false includeDynamicAccessors should default to false (don't include dynamic accessors by default) Jan 8, 2016
@joelittlejohn joelittlejohn added this to the 0.4.19 milestone Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants