Fix javaName breaking required properties #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelittlejohn
added a commit
that referenced
this pull request
Mar 13, 2016
Fix javaName breaking required properties
|
Great, thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of
javaNamerule was causing required properties to not be annotated properly (and probably breaking other things). This PR is intended to fix that by better integrating the feature into the project's structure.javaNameis applied now within theNameHelperclass so that the other modules can take it into account while resolving generated Java fields. This requires passing theJsonNodeof the relevant property to the helper method alongside the property's name. Some of the other modules have been altered to reflect that.