refactor bumpyaml

joemaller · Jan 10, 2022 · 06908a7 · 06908a7
1 parent 625e89d
commit 06908a7
Showing 1 changed file with 23 additions and 28 deletions.
diff --git a/app/lib/bump-yaml.js b/app/lib/bump-yaml.js
@@ -14,33 +14,28 @@ module.exports = function (data, version, config) {
   let prefixData = {};
   let hasVersion = false;
 
-  try {
-    if (config.prefixes.length > 0) {
-      prefixData = bumpPlainText(data, version, config);
-      hasVersion = !!prefixData?.data;
-    }
-
-    /** @type {object} */
-    const yamlObj = YAML.parse(prefixData.data || data);
-
-    // TODO: Does this also need to check for Arrays and Strings?
-    if (yamlObj === null) {
-      throw "YAML.parse() returned null";
-    }
-
-    const yamlData = YAML.parseDocument(prefixData?.data || data, config.yaml);
-    const oldVersion = yamlData.get("version");
-
-    if (!hasVersion) {
-      yamlData.set("version", version);
-    }
-
-    return {
-      oldVersion: oldVersion,
-      data: yamlData.toString(config.yaml),
-    };
-  } catch (err) {
-    // console.log("bumpYAML Error:", err, data);
-    throw err;
+  if (config.prefixes.length > 0) {
+    prefixData = bumpPlainText(data, version, config);
+    hasVersion = !!prefixData?.data;
   }
+
+  /** @type {object} */
+  const yamlObj = YAML.parse(prefixData.data || data);
+
+  // TODO: Does this also need to check for Arrays and Strings?
+  if (yamlObj === null) {
+    throw "YAML.parse() returned null";
+  }
+
+  const yamlData = YAML.parseDocument(prefixData?.data || data, config.yaml);
+  const oldVersion = yamlData.get("version");
+
+  if (!hasVersion) {
+    yamlData.set("version", version);
+  }
+
+  return {
+    oldVersion: oldVersion,
+    data: yamlData.toString(config.yaml),
+  };
 };