Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc Tests to add #15

Closed
4 tasks done
joemaller opened this issue Jan 3, 2020 · 2 comments
Closed
4 tasks done

Misc Tests to add #15

joemaller opened this issue Jan 3, 2020 · 2 comments
Assignees

Comments

@joemaller
Copy link
Owner

joemaller commented Jan 3, 2020

  • Single-line PHP doc /** @version 1.2.3 */
  • PHPdoc with colons * @version: 4.3.2, * @version : 4.3.2
  • PHPdoc with a v prefix * @version v7.1.4
  • YAML with comments and attribute (see comment below) both should update

more to come...

@joemaller joemaller self-assigned this Aug 19, 2023
@joemaller
Copy link
Owner Author

Uncovered in #40, also add tests for yaml files with comments and attributes, eg:

# Leading comment
# Version: 1.2.3
data: "data"
version: 1.2.3

I don't think we need to test the version attribute quoted/unquoted, it's inherently a text string because of the second decimal.

@joemaller
Copy link
Owner Author

joemaller commented Aug 20, 2023

ANY prefix will cause the files to be pre-processed as plain text, so version string in the comment will be updated before the data attribute. That makes sense internally, but it's kind of weird and unintuitive. Should be documented. (ref previous comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant