feat: Add Id to chapters (shaka-project#4184)

Related to shaka-project#3895
joeyparrish · May 3, 2022 · 5ca3271 · 5ca3271
1 parent c2f1fb5
commit 5ca3271
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/externs/shaka/player.js b/externs/shaka/player.js
@@ -1253,11 +1253,14 @@ shaka.extern.Thumbnail;
 
 /**
  * @typedef {{
+ *   id: string,
  *   title: string,
  *   startTime: number,
  *   endTime: number
  * }}
  *
+ * @property {string} id
+ *    The id of the chapter.
  * @property {string} title
  *    The title of the chapter.
  * @property {number} startTime

diff --git a/lib/player.js b/lib/player.js
@@ -4056,8 +4056,13 @@ shaka.Player = class extends shaka.util.FakeEventTarget {
     for (const chaptersTrack of chaptersTracksWithLanguage) {
       if (chaptersTrack && chaptersTrack.cues) {
         for (const cue of chaptersTrack.cues) {
+          let id = cue.id;
+          if (!id || id == '') {
+            id = cue.startTime + '-' + cue.endTime + '-' + cue.text;
+          }
           /** @type {shaka.extern.Chapter} */
           const chapter = {
+            id: id,
             title: cue.text,
             startTime: cue.startTime,
             endTime: cue.endTime,